Uh oh!
There was an error while loading. Please reload this page.
tools: fix Python 3 issues in tools/icu/icutrim.py - #29213
Closed
cclauss wants to merge 3 commits into
Closed
Conversation
srl295
approved these changes
Aug 19, 2019
srl295
left a comment
Member
There was a problem hiding this comment.
LGTM. I guess we are Python 3 only?
cclauss
commented
Aug 19, 2019
ContributorAuthor
No. ensure compatibility with both Python 2 and Python 3. Did I miss something related to Python 2? |
srl295
commented
Aug 19, 2019
Member
@cclauss OK, i see that there. I'm not familiar enough with the similarities I suppose. |
cclauss
commented
Aug 19, 2019
ContributorAuthor
https://docs.python.org/3/library/functions.html#print says:
|
srl295
approved these changes
Aug 19, 2019
63 tasks
gengjiawen
approved these changes
Aug 20, 2019
bnoordhuis
approved these changes
Aug 20, 2019
| if options.locales: | ||
| config["variables"] = config.get("variables", {}) | ||
| config["variables"]["locales"] = config["variables"].get("locales", {}) | ||
| config["variables"]["locales"]["only"] = options.locales.split(',') |
Member
There was a problem hiding this comment.
This file uses 4 space indent so can you use that here too?
(Confusing really since we use 2 space indent everywhere else. Oh well.)
nodejs-github-bot
commented
Aug 20, 2019
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Aug 21, 2019
Collaborator
Trott pushed a commit
that referenced
this pull request
Aug 21, 2019
PR-URL: #29213 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Trott
commented
Aug 21, 2019
Member
Landed in d937b02 |
BridgeAR pushed a commit
that referenced
this pull request
Sep 3, 2019
PR-URL: #29213 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dict.has_key() and file encoding issues in tools/icu/icutrim.py to ensure compatibility with both Python 2 and Python 3.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes