Uh oh!
There was an error while loading. Please reload this page.
src: remove unused using declarations - #29222
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit removes unused using declarations in src/node_contextify.cc.
gengjiawen
approved these changes
Aug 20, 2019
addaleax
approved these changes
Aug 20, 2019
bnoordhuis
approved these changes
Aug 20, 2019
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
FWIW, tools/check-imports.py doesn't catch this because Symbol is used in a comment.
It should have caught the unused v8::Just except it doesn't, probably because it doesn't match at word boundaries. I'll open an issue.
cjihrig
approved these changes
Aug 20, 2019
jasnell
approved these changes
Aug 20, 2019
BridgeAR
approved these changes
Aug 20, 2019
lpinca
approved these changes
Aug 20, 2019
trivikr
approved these changes
Aug 20, 2019
nodejs-github-bot
commented
Aug 21, 2019
Collaborator
nodejs-github-bot
commented
Aug 21, 2019
Collaborator
nodejs-github-bot
commented
Aug 23, 2019
Collaborator
Collaborator
Trott
commented
Aug 23, 2019
Member
Landed in 0e715de |
Trott pushed a commit
that referenced
this pull request
Aug 23, 2019
This commit removes unused using declarations in src/node_contextify.cc. PR-URL: #29222 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 26, 2019
This commit removes unused using declarations in src/node_contextify.cc. PR-URL: #29222 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes unused using declarations in
src/node_contextify.cc.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes