Skip to content

[x] http2: compat ERR_STREAM_ALREADY_FINISHED - #29229

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:http2-already-finished
Closed

[x] http2: compat ERR_STREAM_ALREADY_FINISHED#29229
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:http2-already-finished

Conversation

@ronag

@ronagronag commented Aug 20, 2019

Copy link
Copy Markdown
Member

Make http/2 compat end() match Writable and http/1.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Aug 20, 2019
@ronag
ronagforce-pushed the http2-already-finished branch from dfd3c30 to 3935035CompareAugust 20, 2019 16:54
@jasnelljasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 20, 2019
jasnell
jasnell reviewed Aug 20, 2019
View reviewed changes
Comment threadtest/parallel/test-http2-compat-serverresponse-end.js Outdated
jasnell
jasnell reviewed Aug 20, 2019
View reviewed changes
Comment threadtest/parallel/test-http2-compat-serverresponse-end.js Outdated
jasnell
jasnell reviewed Aug 20, 2019
View reviewed changes
Comment threadtest/parallel/test-http2-compat-serverresponse-end.js Outdated
@ronag
ronagforce-pushed the http2-already-finished branch from 3935035 to 2f4bde0CompareAugust 20, 2019 17:30
@ronag
ronagforce-pushed the http2-already-finished branch 2 times, most recently from 0e21efb to dc9cd5eCompareAugust 20, 2019 19:42
jasnell
jasnell reviewed Aug 22, 2019
View reviewed changes
Comment threadlib/internal/http2/compat.js Outdated
@jasnell

jasnell commented Aug 22, 2019

Copy link
Copy Markdown
Member

Would like to see a CITGM run before landing

@ronag
ronagforce-pushed the http2-already-finished branch from dc9cd5e to 7b11584CompareAugust 22, 2019 19:03
@ronag
http2: compat ERR_STREAM_ALREADY_FINISHED
0605719
Make http/2 compat end() match Writable and http/1.
@ronag
ronagforce-pushed the http2-already-finished branch from 7b11584 to 0605719CompareAugust 22, 2019 22:45
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25194/

@Trott

Trott commented Aug 23, 2019

Copy link
Copy Markdown
Member

CITGM (queued): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1978/

@ronag

ronag commented Sep 20, 2019

Copy link
Copy Markdown
MemberAuthor

This should probably wait for #24347 before merging.

@sogaanisogaani mentioned this pull request Oct 3, 2019
Closed
32 tasks
@ronag

ronag commented Dec 15, 2019

Copy link
Copy Markdown
MemberAuthor

I'm closing this for now. It's been blocked for quite a while by #24347 and the problem is currently tracked in #29829. I'll re-open if/when it becomes relevant again.

@ronagronag closed this Dec 15, 2019
@ronagronag changed the title http2: compat ERR_STREAM_ALREADY_FINISHED[x] http2: compat ERR_STREAM_ALREADY_FINISHEDDec 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@trivikrtrivikrtrivikr approved these changes
@mcollinamcollinaAwaiting requested review from mcollina
@addaleaxaddaleaxAwaiting requested review from addaleax

Assignees

No one assigned

Labels

http2Issues or PRs related to the http2 subsystem.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag@jasnell@nodejs-github-bot@Trott@trivikr