Uh oh!
There was an error while loading. Please reload this page.
test: fix 'timeout' typos - #29234
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
I don't think so, Tim.
richardlau
approved these changes
Aug 20, 2019
Trott
approved these changes
Aug 21, 2019
danbev
commented
Aug 21, 2019
Contributor
ZYSzys
approved these changes
Aug 21, 2019
lpinca
approved these changes
Aug 21, 2019
jasnell
approved these changes
Aug 21, 2019
nodejs-github-bot
commented
Aug 21, 2019
Collaborator
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/25151/ EDIT: Only infra-related failures on ARM from the CI run, while this patch only impacts Windows. |
nodejs-github-bot
commented
Aug 21, 2019
Collaborator
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/25189/ EDIT: CI was green. |
Trott
commented
Aug 23, 2019
Member
Landed in 6c5ca74 |
Trott pushed a commit
that referenced
this pull request
Aug 23, 2019
I don't think so, Tim. PR-URL: #29234 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 26, 2019
I don't think so, Tim. PR-URL: #29234 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes