Skip to content

Revert "http: simplify drain()" - #29244

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:revert-for-12.9.1
Closed

Revert "http: simplify drain()"#29244
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:revert-for-12.9.1

Conversation

@Trott

@TrottTrott commented Aug 21, 2019

Copy link
Copy Markdown
Member

This reverts commit bdf07f4.

The commit causes somewhat rampant MaxListenerExceeded warnings on
fairly generic npm installs.

Fixes: #29239

Collaborators: 👍 here to fast-track

@mcollina@targos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
Revert "http: simplify drain()"
cefd461
This reverts commit bdf07f4.
The commit causes somewhat rampant MaxListenerExceeded warnings on
fairly generic npm installs.
Fixes: nodejs#29239
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 21, 2019
@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 21, 2019
@TrottTrott mentioned this pull request Aug 21, 2019
Closed
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25142/

mcollina
mcollina approved these changes Aug 21, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos

targos commented Aug 21, 2019

Copy link
Copy Markdown
Member

LGTM but I'm not available to prepare a release today

@ronagronag mentioned this pull request Aug 21, 2019
Closed
4 tasks
@ronag

ronag commented Aug 21, 2019

Copy link
Copy Markdown
Member

Alternative fix if desired #29245.

@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25146/

@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25156/

@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25159/

@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25185/

@Trott

Trott commented Aug 23, 2019

Copy link
Copy Markdown
MemberAuthor

Talked offline with @jasnell who felt that #29245 was preferable, so I'll close this. Feel free to re-open (or easy enough to do another revert PR separate from this) if #29245 stalls or otherwise doesn't work out.

@TrottTrott closed this Aug 23, 2019
@Trott
Trott deleted the revert-for-12.9.1 branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@cjihrigcjihrigcjihrig approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@silverwindsilverwindsilverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12.9.0 MaxListenersExceededWarning

8 participants

@Trott@nodejs-github-bot@targos@ronag@mcollina@silverwind@cjihrig@trivikr