Skip to content

deps: upgrade npm to 6.11.2 - #29273

Closed
isaacs wants to merge 1 commit into
nodejs:masterfrom
npm:npm-v6.11.2
Closed

deps: upgrade npm to 6.11.2#29273
isaacs wants to merge 1 commit into
nodejs:masterfrom
npm:npm-v6.11.2

Conversation

@isaacs

Copy link
Copy Markdown
Contributor

This fixes the last of the Windows regressions in 6.11.0.

Changelog:

6.11.2 (2019-08-22):

Fix a recent Windows regression, and two long-standing Windows bugs. Also, get CI running on Windows, so these things are less likely in the future.

DEPENDENCIES

  • 9778a1b87cmd-shim@3.0.3: Fix regression where shims fail to preserve exit code (@isaacs)
  • bf93e91d8npm-package-arg@6.1.1: Properly handle git+file: urls on Windows when a drive letter is included. (@isaacs)

BUGFIXES

  • 6cc4cc66f escape args properly on Windows Bash Despite being bash, Node.js running on windows git mingw bash still executes child processes using cmd.exe. As a result, arguments in this environment need to be escaped in the style of cmd.exe, not bash. (@isaacs)

TESTS

@nodejs-github-botnodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Aug 22, 2019

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott

Copy link
Copy Markdown
Member

This can land on or after September 5.

@Trott

Copy link
Copy Markdown
Member

@ZYSzysZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@danbev

Copy link
Copy Markdown
Contributor

This can land on or after September 5.

@Trott Just curious about the reason for waiting until September 5 for this? (just for future reference)

@Trott

Copy link
Copy Markdown
Member

This can land on or after September 5.

@Trott Just curious about the reason for waiting until September 5 for this? (just for future reference)

We have a rule that new npm versions wait two weeks after their release before landing them in Node.js master. That caution may be outdated and we may wish to revisit it. Or maybe it is serving us well. But in either case, I post those notes because people (understandably) forget that npm PRs are handled differently from other PRs.

@lpinca

Copy link
Copy Markdown
Member

Superseded by #29430.

@lpincalpinca closed this Oct 12, 2019
@wraithgar
wraithgar deleted the npm-v6.11.2 branch June 26, 2025 15:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@isaacs@nodejs-github-bot@Trott@danbev@lpinca@gengjiawen@trivikr@ZYSzys