Skip to content

doc,crypto: add extends for derived classes - #29302

Merged
trivikr merged 1 commit into
nodejs:masterfrom
trivikr:doc-crypto-extends
Aug 29, 2019
Merged

doc,crypto: add extends for derived classes#29302
trivikr merged 1 commit into
nodejs:masterfrom
trivikr:doc-crypto-extends

Conversation

@trivikr

@trivikrtrivikr commented Aug 25, 2019

Copy link
Copy Markdown
Member
Checklist

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Aug 25, 2019
@trivikr

trivikr commented Aug 26, 2019

Copy link
Copy Markdown
MemberAuthor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3856/

@trivikrtrivikr self-assigned this Aug 26, 2019
@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 26, 2019
lpinca
lpinca approved these changes Aug 26, 2019
View reviewed changes
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
Comment threaddoc/api/crypto.md Outdated
@trivikrtrivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 26, 2019
@trivikr

trivikr commented Aug 26, 2019

Copy link
Copy Markdown
MemberAuthor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3858/

@trivikr

trivikr commented Aug 27, 2019

Copy link
Copy Markdown
MemberAuthor

Ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3859/

@trivikrtrivikr mentioned this pull request Aug 27, 2019
Merged
7 tasks
@trivikr

trivikr commented Aug 28, 2019

Copy link
Copy Markdown
MemberAuthor

@nodejs/crypto

@Trott

Trott commented Aug 29, 2019

Copy link
Copy Markdown
Member

@trivikr Any reason to hold off on landing this?

@trivikr

trivikr commented Aug 29, 2019

Copy link
Copy Markdown
MemberAuthor

Yet to get approvals after latest commit ce60c8ca703c654d2953330291f8c58bab0cdbea
Ping @jasnell@lpinca

@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2019
@trivikr
doc,crypto: add extends for derived classes
c746ba4
PR-URL: nodejs#29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@trivikr

trivikr commented Aug 29, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in c746ba4

@trivikr
trivikr merged commit c746ba4 into nodejs:masterAug 29, 2019
@trivikr
trivikr deleted the doc-crypto-extends branch August 29, 2019 22:23
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@trivikr@BridgeAR
doc,crypto: add extends for derived classes
8c776cb
PR-URL: #29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeARBridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@trivikr@BridgeAR
doc,crypto: add extends for derived classes
ae810cc
PR-URL: #29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes

Assignees

@trivikrtrivikr

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trivikr@Trott@jasnell@lpinca@nodejs-github-bot