Uh oh!
There was an error while loading. Please reload this page.
doc: remove spaces inside code span elements - #29329
Closed
nschonni wants to merge 2 commits into
Closed
Conversation
nschonni
commented
Aug 27, 2019
MemberAuthor
@Trott from the discussion from nodejs/nodejs.org#2458 (comment) this is just trying to fixup some of the diffs between what remark and markdownlint cover rather than swap them |
nschonniforce-pushed
the
fix--MD038/no-space-in-code
branch
from
August 27, 2019 03:52
0c826c5 to
59fe47cCompareTrott
reviewed
Aug 27, 2019
Uh oh!
There was an error while loading. Please reload this page.
Trott
commented
Aug 27, 2019
Member
Looks good except for that one link thing. Not sure what the right answer to that one is. |
Trott
approved these changes
Aug 27, 2019
Trott
left a comment
Member
There was a problem hiding this comment.
Would love for the one item we're commenting about to get resolved, but this change doesn't make it any worse, so LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lpinca
approved these changes
Aug 27, 2019
nschonniforce-pushed
the
fix--MD038/no-space-in-code
branch
from
August 27, 2019 22:28
59fe47c to
8097af1Comparedanbev
commented
Aug 29, 2019
Contributor
jasnell
approved these changes
Aug 29, 2019
trivikr
approved these changes
Aug 30, 2019
nschonniforce-pushed
the
fix--MD038/no-space-in-code
branch
from
October 2, 2019 05:19
8097af1 to
856cc17CompareApplies MarkdownLint MD038 rule
Applies MarkdownLint MD038 rule
nschonniforce-pushed
the
fix--MD038/no-space-in-code
branch
from
October 9, 2019 23:27
856cc17 to
5887a6cCompareTrott
commented
Oct 10, 2019
Member
Trott
commented
Oct 10, 2019
Member
Landed in b41989d...63f5a76 |
Trott pushed a commit
that referenced
this pull request
Oct 10, 2019
Applies MarkdownLint MD038 rule PR-URL: #29329 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott pushed a commit
that referenced
this pull request
Oct 10, 2019
Applies MarkdownLint MD038 rule PR-URL: #29329 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Oct 10, 2019
Applies MarkdownLint MD038 rule PR-URL: #29329 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Oct 10, 2019
Applies MarkdownLint MD038 rule PR-URL: #29329 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes