Uh oh!
There was an error while loading. Please reload this page.
doc: indent ordered list child content - #29332
Closed
nschonni wants to merge 1 commit into
Closed
Conversation
cclauss
commented
Aug 27, 2019
Contributor
nschonni
commented
Aug 27, 2019
MemberAuthor
@cclauss thanks, I re-wrapped the lines to make the 80 character rule happy |
Trott
commented
Aug 29, 2019
Member
Trott
commented
Aug 29, 2019
Member
@nodejs/documentation |
Trott
commented
Aug 31, 2019
Member
Can you rebase to get rid of the merge conflict? |
Markdownlint flags this with MD029 rule. Markdown renders will usually use list continuation number if it can. Explicitly adding it to the list item child scope makes it clearer.
nschonni
commented
Aug 31, 2019
MemberAuthor
@Trott rebased for the conflict |
Trott
approved these changes
Sep 1, 2019
Trott
commented
Sep 1, 2019
Member
trivikr
approved these changes
Sep 1, 2019
danbev pushed a commit
that referenced
this pull request
Sep 6, 2019
Markdownlint flags this with MD029 rule. Markdown renders will usually use list continuation number if it can. Explicitly adding it to the list item child scope makes it clearer. PR-URL: #29332 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
danbev
commented
Sep 6, 2019
Contributor
Landed in 754d5a9. |
targos pushed a commit
that referenced
this pull request
Sep 20, 2019
Markdownlint flags this with MD029 rule. Markdown renders will usually use list continuation number if it can. Explicitly adding it to the list item child scope makes it clearer. PR-URL: #29332 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes