Skip to content

test: fix flaky test-http-server-keepalive-req-gc - #29347

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-req-gc-test
Closed

test: fix flaky test-http-server-keepalive-req-gc#29347
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-req-gc-test

Conversation

@Trott

@TrottTrott commented Aug 27, 2019

Copy link
Copy Markdown
Member

Use server to keep the event loop open until the ongc listener runs.

Fixes: #29344

Collaborators, please 👍 to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@TrottTrott added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 27, 2019
@TrottTrott mentioned this pull request Aug 27, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
addaleax
addaleax reviewed Aug 27, 2019
View reviewed changes
Comment threadtest/parallel/test-http-server-keepalive-req-gc.js Outdated
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25275/

@TrottTrott changed the title test: fix falky test-http-server-keepalive-req-gctest: fix flaky test-http-server-keepalive-req-gcAug 27, 2019
@Trott

Trott commented Aug 27, 2019

Copy link
Copy Markdown
MemberAuthor

CI is green. Some approvals for fast-tracking would be great.... @nodejs/testing

@Trott
test: fix flaky test-http-server-keepalive-req-gc
512d01a
Use `server` to keep the event loop open until the `ongc` listener runs.
Fixes: nodejs#29344
@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25278/

@addaleax

addaleax commented Aug 27, 2019

Copy link
Copy Markdown
Member

Actually, can you maybe also try to remove the skip-on-Windows part? That might be resolved now too

@Trott

Trott commented Aug 27, 2019

Copy link
Copy Markdown
MemberAuthor

Actually, can you maybe also try to remove the skip-on-Windows part? That might be resolved now too

I was going to do that in a follow-up PR, just in case it's not resolved. Is that OK with you?

@addaleax

addaleax commented Aug 27, 2019

Copy link
Copy Markdown
Member

Sure!

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 28, 2019
@Trott

Trott commented Aug 28, 2019

Copy link
Copy Markdown
MemberAuthor

Collaborators, please 👍 to fast-track.

danbev pushed a commit that referenced this pull request Aug 28, 2019
@Trott@danbev
test: fix flaky test-http-server-keepalive-req-gc
3ae6f5e
Use `server` to keep the event loop open until the `ongc` listener runs.
PR-URL: #29347Fixes: #29344
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@danbev

danbev commented Aug 28, 2019

Copy link
Copy Markdown
Contributor

Landed in 3ae6f5e.

@danbevdanbev closed this Aug 28, 2019
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@Trott@BridgeAR
test: fix flaky test-http-server-keepalive-req-gc
e3cfbba
Use `server` to keep the event loop open until the `ongc` listener runs.
PR-URL: #29347Fixes: #29344
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeARBridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@Trott@BridgeAR
test: fix flaky test-http-server-keepalive-req-gc
bd1e8ea
Use `server` to keep the event loop open until the `ongc` listener runs.
PR-URL: #29347Fixes: #29344
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott
Trott deleted the fix-req-gc-test branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@danbevdanbevdanbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky test-http-server-keepalive-req-gc.js

4 participants

@Trott@nodejs-github-bot@addaleax@danbev