Uh oh!
There was an error while loading. Please reload this page.
test: remove Windows skipping of http keepalive request GC test - #29354
Closed
Trott wants to merge 1 commit into
Closed
test: remove Windows skipping of http keepalive request GC test#29354Trott wants to merge 1 commit into
Trott wants to merge 1 commit into
Conversation
Remove code to skip Windows in test-http-server-keepalive-req-gc. The test now works reliably on Windows (I think).
nodejs-github-bot
commented
Aug 28, 2019
Collaborator
Trott
commented
Aug 28, 2019
MemberAuthor
(The test passed on all four Windows variants in CI.) |
addaleax
approved these changes
Aug 28, 2019
cjihrig
approved these changes
Aug 28, 2019
lpinca
approved these changes
Aug 28, 2019
jasnell
approved these changes
Aug 28, 2019
richardlau
approved these changes
Aug 28, 2019
ChALkeR
approved these changes
Aug 28, 2019
devnexen
approved these changes
Aug 30, 2019
Trott added a commit
that referenced
this pull request
Aug 30, 2019
Remove code to skip Windows in test-http-server-keepalive-req-gc. The test now works reliably on Windows (I think). PR-URL: #29354 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Trott
commented
Aug 30, 2019
MemberAuthor
Landed in 9e52654 |
BridgeAR pushed a commit
that referenced
this pull request
Sep 3, 2019
Remove code to skip Windows in test-http-server-keepalive-req-gc. The test now works reliably on Windows (I think). PR-URL: #29354 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
BridgeAR pushed a commit
that referenced
this pull request
Sep 4, 2019
Remove code to skip Windows in test-http-server-keepalive-req-gc. The test now works reliably on Windows (I think). PR-URL: #29354 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove code to skip Windows in test-http-server-keepalive-req-gc. The
test now works reliably on Windows (I think).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes