doc: update experimental loader hooks example code

[zaverden]

It fix 2 issues in provided Loader hooks examples:

1. Original new URL(`${process.cwd()}/`, 'file://');
   is not cross-platform, it gives wrong URL on windows
2. Based on CHECK in ModuleWrap::Resolve (node 12.9.1,
   https://github.com/nodejs/node/blob/v12.9.1/src/module_wrap.cc#L1132)
   the 2nd parameter should be a string, not an URL object

Checklist

• documentation is changed or added
• commit message follows commit guidelines

[devnexen]

Hi and thanks for your contribution.

Please pay attention to https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines

Also make lint to make sure all the changes fits the general styles.

[zaverden]

@devnexen thank you for pointing it out. Commit message is updated and make lint runs without errors now.

[zaverden]

I have rebased my branch to the right head (finally).
@lpinca@vsemozhetbyt do you have any other comments?

[devnexen]

One last approval maybe @lpinca but regardless I may push it soon-ish :-)

[devnexen]

Landed in ff78c167b123e

[Trott]

Landed in ff78c16

Unfortunately, the PR-URL is invalid. It needs to be a full URL. Since this landed 20 hours ago, I think we're stuck with it. Did you do this manually rather than using node-core-utils/git node land?

[devnexen]

Sorry my mistake indeed.

[Trott]

Sorry my mistake indeed.

Yeah, it's all right, it's happened before and will happen again. One more reason to get a commit queue going so we don't have to manually land stuff at all! 😀

[Trott]

After some brief discussion in #node-dev IRC, I fixed and force-pushed.

[sam-github]

@devnexen did you not use git node land, or did you not accept the amend option when prompted? I've done the latter before.

We might be able to use github actions to refuse commits that don't have metadata.

Personally, I think long-term traceability of the code changes is more important than short-term discomfort of any (possibly none) devs who don't use rebase, and get confused. The main reason to not rewrite history is it can cause pain and confusing branches to get merged... but we won't land confusing branch history, so anyone working on nodejs/node itself won't be affected.