doc: make execFileSync in line with execFile by lfortin · Pull Request #2940 · nodejs/node

lfortin · 2015-09-18T00:53:36Z

Make execFileSync API docs in line with execFile API docs.

make execFileSync API docs in line with execFile API docs

evanlucas · 2015-09-18T01:32:23Z

LGTM

silverwind · 2015-09-22T15:30:22Z

@lfortin while you're at it, could you move the whole execFileSync section below exexSync so the ordering is the same as for the async methods?

lfortin · 2015-09-22T17:51:01Z

@silverwind done.

silverwind · 2015-09-22T17:52:59Z

@lfortin The diff looks a bit unwieldy, this is just a cut-paste job, right?

lfortin · 2015-09-22T18:06:12Z

@silverwind yes it is. I confirm that the text is well formatted.

silverwind · 2015-09-22T18:17:47Z

Alright, LGTM.

targos · 2015-09-22T18:35:24Z

I'm not sure these should have moved. Isn't there a convention to put the link definitions at the end of the file ?

Oh, good catch. These should indeed remain an the end of the file, @lfortin.

lfortin · 2015-09-22T18:43:18Z

@targos I see, my bad. I will re-issue a new commit with the link definitions at the end of the file.

/cc @silverwind

lfortin · 2015-09-22T18:50:59Z

@targos @silverwind done.

silverwind · 2015-09-22T18:55:50Z

I'm sorry but this looks like an unnecessary newline.

rearrange execSync, execFileSync API docs to be in line with exec, execFile API docs

lfortin · 2015-09-22T19:04:51Z

@silverwind unnecessary new line removed.

silverwind · 2015-09-22T19:07:15Z

LGTM

targos · 2015-09-22T19:10:26Z

LGTM

PR-URL: #2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

Changed the ordering so it is in line with the async methods. PR-URL: #2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

silverwind · 2015-09-23T20:23:22Z

Thanks, landed in 28da400 and 2d21092.

PR-URL: #2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

Changed the ordering so it is in line with the async methods. PR-URL: #2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

doc: make execFileSync in line with execFile
66a6f76
make execFileSync API docs in line with execFile API docs

brendanashworth added the doc Issues and PRs related to the documentations. label Sep 18, 2015

mscdex added the child_process Issues and PRs related to the child_process subsystem. label Sep 18, 2015

lfortin force-pushed the doc-execfilesync branch from 103d869 to 66a6f76Compare September 22, 2015 17:21

targos reviewed Sep 22, 2015
View reviewed changes

lfortin force-pushed the doc-execfilesync branch from 6b69b3d to 66a6f76Compare September 22, 2015 18:46

silverwind reviewed Sep 22, 2015
View reviewed changes

Comment threaddoc/api/child_process.markdown Outdated
silverwindSep 22, 2015
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but this looks like an unnecessary newline.

lfortin force-pushed the doc-execfilesync branch from e05bb82 to 66a6f76Compare September 22, 2015 18:58

doc: rearrange execSync, execFileSync in line with exec, execFile
0134d9c
rearrange execSync, execFileSync API docs to be in line with exec, execFile API docs

silverwind pushed a commit that referenced this pull request Sep 23, 2015
doc: make execFileSync in line with execFile
28da400
PR-URL: #2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

silverwind pushed a commit that referenced this pull request Sep 23, 2015
doc: rearrange execSync and execFileSync
2d21092
Changed the ordering so it is in line with the async methods. PR-URL: #2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

silverwind closed this Sep 23, 2015

Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
doc: make execFileSync in line with execFile
4fc33ac
PR-URL: #2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

Fishrock123 pushed a commit that referenced this pull request Sep 25, 2015
doc: rearrange execSync and execFileSync
5c3f50b
Changed the ordering so it is in line with the async methods. PR-URL: #2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>

This was referenced Sep 30, 2015
Release proposal: v4.1.2 #3127
Closed
Release proposal: v4.1.2 #3128
Closed

Uh oh!

Uh oh!

Conversation

lfortin commented Sep 18, 2015

Uh oh!

evanlucas commented Sep 18, 2015

Uh oh!

silverwind commented Sep 22, 2015

Uh oh!

lfortin commented Sep 22, 2015

Uh oh!

silverwind commented Sep 22, 2015

Uh oh!

lfortin commented Sep 22, 2015

Uh oh!

silverwind commented Sep 22, 2015

Uh oh!

targosSep 22, 2015

Choose a reason for hiding this comment

Uh oh!

silverwindSep 22, 2015

Choose a reason for hiding this comment

Uh oh!

lfortin commented Sep 22, 2015

Uh oh!

lfortin commented Sep 22, 2015

Uh oh!

silverwindSep 22, 2015

Choose a reason for hiding this comment

Uh oh!

lfortin commented Sep 22, 2015

Uh oh!

silverwind commented Sep 22, 2015

Uh oh!

targos commented Sep 22, 2015

Uh oh!

silverwind commented Sep 23, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants