Skip to content

repl: add autocomplete support for fs.promises - #29400

Closed
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:master
Closed

repl: add autocomplete support for fs.promises#29400
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:master

Conversation

@antsmartian

@antsmartianantsmartian commented Sep 2, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up of this #26648. Adding support for fs.promises also updated the test files.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Sep 2, 2019
@antsmartian

antsmartian commented Sep 2, 2019

Copy link
Copy Markdown
ContributorAuthor

ping @nodejs/repl

@antsmartianantsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2019
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25359/

@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25363/

@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25364/

BridgeAR
BridgeAR approved these changes Sep 5, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

Comment threadtest/parallel/test-repl-tab-complete.js Outdated
Comment threadlib/repl.js Outdated
@TrottTrott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 7, 2019
@Trott

Trott commented Sep 7, 2019

Copy link
Copy Markdown
Member

Removed author ready because there are nits. This can still land as the nits here look optional, but they seem like good suggestions I think so might as well?

addaleax
addaleax approved these changes Sep 7, 2019
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I’m okay with fixing the nits while landing or separately

@antsmartian

antsmartian commented Sep 10, 2019

Copy link
Copy Markdown
ContributorAuthor

Ping @addaleax@BridgeAR . Addressed nits.. Could you please have a look at this now?

@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25414/

@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25415/

@ZYSzysZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 15, 2019
@Trott

Trott commented Sep 16, 2019

Copy link
Copy Markdown
Member

Landed in ed0e5c8

Trott pushed a commit that referenced this pull request Sep 16, 2019
@antsmartian@Trott
repl: add autocomplete support for fs.promises
ed0e5c8
PR-URL: #29400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@TrottTrott closed this Sep 16, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
@antsmartian@targos
repl: add autocomplete support for fs.promises
d57d47b
PR-URL: #29400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeARBridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@antsmartian@BridgeAR
repl: add autocomplete support for fs.promises
596dd9f
PR-URL: #29400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@ZYSzysZYSzysZYSzys approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.replIssues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@antsmartian@nodejs-github-bot@Trott@jasnell@addaleax@BridgeAR@ZYSzys