Skip to content

[v10.x] n-api: mark version 5 N-APIs as stable - #29458

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:v10.x-stagingfrom
gabrielschulhof:backport-29401-to-v10.x
Closed

[v10.x] n-api: mark version 5 N-APIs as stable#29458
gabrielschulhof wants to merge 1 commit into
nodejs:v10.x-stagingfrom
gabrielschulhof:backport-29401-to-v10.x

Conversation

@gabrielschulhof

@gabrielschulhofgabrielschulhof commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

PR-URL: #29401

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Gabriel Schulhof
n-api: mark version 5 N-APIs as stable
fc29c08
PR-URL: nodejs#29401
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v10.x labels Sep 5, 2019
@richardlau

richardlau commented Sep 5, 2019

Copy link
Copy Markdown
Member

I suggest updating N-API Version Matrix with a new column for 5 and REPLACEME as the placeholder for the value in the v10.x row.

@gabrielschulhof

gabrielschulhof commented Sep 5, 2019

Copy link
Copy Markdown
ContributorAuthor

@richardlau I created #29461 which I can then backport. Is that how you envisioned it?

@mhdawson

mhdawson commented Sep 5, 2019

Copy link
Copy Markdown
Member

@gabrielschulhof, @richardlau not sure if a PR with REPLACEME's for all of the version make sense as I don't think you'll be able to land until those are replaced or they might get replaced with the wrong version?

mhdawson
mhdawson approved these changes Sep 5, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau

richardlau commented Sep 5, 2019

Copy link
Copy Markdown
Member

I envision that each backport would have a single REPLACEME in the appropriate row so that when the release is later cut it is replaced with the version being released as part of the release process: https://github.com/nodejs/node/blob/master/doc/releases.md#step-3-update-any-replaceme-and-dep00xx-tags-in-the-docs

@gabrielschulhofgabrielschulhof mentioned this pull request Sep 9, 2019
Closed
@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25583/

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2019•
edited by BethGriggs
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25585/ ✅

@mhdawson

mhdawson commented Sep 30, 2019

Copy link
Copy Markdown
Member

@BethGriggs I assume this will be part of the next 10.x SemVer minor?

BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
Gabriel Schulhof@BethGriggs
n-api: mark version 5 N-APIs as stable
c74c6a5
PR-URL: #29401
Backport-PR-URL: #29458
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs

BethGriggs commented Oct 1, 2019

Copy link
Copy Markdown
Member

Landed on v10.x-staging

@gabrielschulhof
gabrielschulhof deleted the backport-29401-to-v10.x branch March 13, 2020 06:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethGriggsBethGriggsBethGriggs approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabrielschulhof@richardlau@mhdawson@nodejs-github-bot@BethGriggs