Uh oh!
There was an error while loading. Please reload this page.
perf_hooks: remove not exist entries from inspect - #29528
Closed
fanatid wants to merge 2 commits into
Closed
Conversation
Some of the milestones was removed in PR nodejs#21247 but entries not removed from function for inspect PerformanceNodeTiming.
jasnell
approved these changes
Sep 11, 2019
trivikr
commented
Sep 11, 2019
Member
@jasnell Should these be removed from node/test/parallel/test-trace-events-bootstrap.js Lines 16 to 23 in 23f8b7d |
addaleax
approved these changes
Sep 11, 2019
jasnell
commented
Sep 11, 2019
Member
Yeah they should |
trivikr
approved these changes
Sep 11, 2019
trivikr
commented
Sep 11, 2019
Member
@fanatid would you also like to remove following entries in this PR? node/test/parallel/test-trace-events-bootstrap.js Lines 16 to 23 in 23f8b7d |
cjihrig
approved these changes
Sep 12, 2019
fanatid
commented
Sep 12, 2019
ContributorAuthor
Removed. |
trivikr
approved these changes
Sep 12, 2019
trivikr
commented
Sep 12, 2019
Member
nodejs-github-bot
commented
Sep 12, 2019
Collaborator
Trott
commented
Sep 13, 2019
Member
Landed in 39eb894 |
Trott pushed a commit
that referenced
this pull request
Sep 13, 2019
Some of the milestones was removed in PR #21247 but entries not removed from function for inspect PerformanceNodeTiming. PR-URL: #29528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
Sep 20, 2019
Some of the milestones was removed in PR #21247 but entries not removed from function for inspect PerformanceNodeTiming. PR-URL: #29528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
BridgeAR pushed a commit
that referenced
this pull request
Sep 25, 2019
Some of the milestones was removed in PR #21247 but entries not removed from function for inspect PerformanceNodeTiming. PR-URL: #29528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Sep 25, 2019
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the milestones was removed in PR #21247 but entries not removed
from function for inspect PerformanceNodeTiming.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes