perf_hooks: add property flags to GCPerformanceEntry by fanatid · Pull Request #29547 · nodejs/node

fanatid · 2019-09-13T14:32:14Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

perf_hooks have kind for GC, but do not have flags

nodejs-github-bot · 2019-11-30T17:33:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27228/

nodejs-github-bot · 2019-12-06T18:46:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27410/

Trott · 2019-12-06T18:46:40Z

This could use more reviews. /cc @nodejs/performance

addaleax · 2019-12-06T18:50:02Z

This LGTM code-wise, but it doesn’t really seem to document what these flags indicate (although I guess the same is true for .kind…)

joyeecheung · 2019-12-08T15:48:17Z

If we are exposing this we at least need a note similar to the one in https://nodejs.org/api/v8.html#v8_v8_getheapspacestatistics
Neither the ordering of heap spaces, nor the availability of a heap space can be guaranteed as the statistics are provided via the V8 GetHeapSpaceStatistics function and may change from one V8 version to the next.
As compared to the GC kind the flags here seem to be even less stable.
This also lacks explanation and they are less self-explanatory compared to the gc kinds. I guess we could link to the v8 docs of GCCallbackFlags at least for reference.

This flags provided via V8 GCCallbackFlags enum and may change from one V8 version to next.
Looks good for adding after constants list?

BridgeAR · 2020-01-12T02:09:42Z

This needs a rebase.

fanatid · 2020-01-12T05:53:02Z

Rebased.

nodejs-github-bot · 2020-01-12T11:43:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28398/

nodejs-github-bot · 2020-01-12T15:16:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28409/

nodejs-github-bot · 2020-02-02T08:16:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28872/

nodejs-github-bot · 2020-02-02T13:16:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28876/

nodejs-github-bot · 2020-02-03T05:42:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28890/

jasnell · 2020-02-03T20:31:55Z

Failure in CI does not appear relevant but kicked off a new CI just in case

nodejs-github-bot · 2020-02-03T20:32:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28899/

nodejs-github-bot · 2020-02-03T23:26:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28902/

PR-URL: #29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

addaleax · 2020-02-04T16:42:26Z

Landed in 018c3e8

PR-URL: #29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Notable changes: * async_hooks * add executionAsyncResource (Matteo Collina) #30959 * crypto * add crypto.diffieHellman (Tobias Nießen) #31178 * add DH support to generateKeyPair (Tobias Nießen) #31178 * simplify DH groups (Tobias Nießen) #31178 * add key type 'dh' (Tobias Nießen) #31178 * test * skip keygen tests on arm systems (Tobias Nießen) #31178 * perf_hooks * add property flags to GCPerformanceEntry (Kirill Fomichev) #29547 * process * report ArrayBuffer memory in `memoryUsage()` (Anna Henningsen) #31550 * readline * make tab size configurable (Ruben Bridgewater) #31318 * report * add support for Workers (Anna Henningsen) #31386 * worker * add ability to take heap snapshot from parent thread (Anna Henningsen) #31569 * added new collaborators * add ronag to collaborators (Robert Nagy) #31498 PR-URL: #31837

PR-URL: nodejs#29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 13, 2019

fanatid commented Sep 13, 2019
View reviewed changes

Comment threaddoc/api/perf_hooks.md Outdated

jasnell approved these changes Sep 16, 2019
View reviewed changes

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 16, 2019

Trott force-pushed the master branch from 1ecc406 to 49cf67eCompare September 17, 2019 16:50

addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Nov 30, 2019

Trott reviewed Dec 6, 2019
View reviewed changes

Comment threaddoc/api/perf_hooks.md Outdated

Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 6, 2019

joyeecheung reviewed Dec 8, 2019
View reviewed changes

fanatid added 4 commits January 12, 2020 08:51

perf_hooks: add property flags to GCPerformanceEntry
ca67e58

perf_hooks: REPLACEME instead version in docs
f23b4ff

perf_hooks: fix lint-cpp
4b55aac

perf_hooks: fix REPLACEME in doc
36b01b7

fanatid force-pushed the perf_hooks-add-flags-for-gc branch from 86b0aa0 to 36b01b7Compare January 12, 2020 05:52

BridgeAR reviewed Jan 12, 2020
View reviewed changes

Comment threadtest/parallel/test-performance-gc.js Outdated

perf_hooks: remove empty line in test
d5e1a8a

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2020

legendecas approved these changes Feb 2, 2020
View reviewed changes

Trott reviewed Feb 2, 2020
View reviewed changes

Comment threaddoc/api/perf_hooks.md Outdated

perf_hooks: adjust words in doc
bce3cb6

addaleax pushed a commit that referenced this pull request Feb 4, 2020
perf_hooks: add property flags to GCPerformanceEntry
018c3e8
PR-URL: #29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

addaleax closed this Feb 4, 2020

fanatid deleted the perf_hooks-add-flags-for-gc branch February 4, 2020 16:43

codebytere pushed a commit that referenced this pull request Feb 17, 2020
perf_hooks: add property flags to GCPerformanceEntry
e7fea14
PR-URL: #29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

codebytere mentioned this pull request Feb 17, 2020
v13.9.0 proposal #31837
Merged

targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020

targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
perf_hooks: add property flags to GCPerformanceEntry
055d054
PR-URL: nodejs#29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

targos pushed a commit that referenced this pull request Apr 28, 2020
perf_hooks: add property flags to GCPerformanceEntry
9eeee0d
PR-URL: #29547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged

Uh oh!

Uh oh!

Conversation

fanatid commented Sep 13, 2019

Checklist

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 30, 2019

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 6, 2019

Uh oh!

Trott commented Dec 6, 2019

Uh oh!

addaleax commented Dec 6, 2019

Uh oh!

joyeecheungDec 8, 2019

Choose a reason for hiding this comment

Uh oh!

fanatidDec 8, 2019

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Jan 12, 2020

Uh oh!

fanatid commented Jan 12, 2020

Uh oh!

nodejs-github-bot commented Jan 12, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 12, 2020

Uh oh!

nodejs-github-bot commented Feb 2, 2020

Uh oh!

nodejs-github-bot commented Feb 2, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 3, 2020

Uh oh!

jasnell commented Feb 3, 2020

Uh oh!

nodejs-github-bot commented Feb 3, 2020

Uh oh!

nodejs-github-bot commented Feb 3, 2020

Uh oh!

addaleax commented Feb 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants