bootstrap: adds exception handling for profiler bootstrap by shobhitchittora · Pull Request #29552 · nodejs/node

shobhitchittora · 2019-09-14T00:11:47Z

The bootstrapping of profiler failed the script evaluation when inspector is disabled. Adding a try-catch block to handle that and emit a warning.

Fixes: #29542

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

shobhitchittora · 2019-09-14T00:33:55Z

@addaleax The warning message can be better here. Any suggestions? Any straightforward way to write a test for this. Thinking of emitting the warning from child to parent and then asserting that.

devsnek · 2019-09-14T00:43:27Z

how about "The inspector is disabled, coverage could not be collected"

addaleax · 2019-09-14T09:48:31Z

@addaleax The warning message can be better here. Any suggestions?

I think something along @devsnek’s suggestion is fine.

Any straightforward way to write a test for this. Thinking of emitting the warning from child to parent and then asserting that.

Yeah, spawning a child process that emits this warning and then checking its output would be the easiest way to test this 👍

shobhitchittora · 2019-09-15T11:57:58Z

Both
./node ./test/parallel/test-coverage-with-inspector-disabled.js
and
python tools/test.py test/parallel/test-coverage-with-inspector-disabled.js
work fine for me on local, but the test is fails in CI. I might be missing something here. Is the child spawned correctly in the test added?

addaleax

Both
./node ./test/parallel/test-coverage-with-inspector-disabled.js
and
python tools/test.py test/parallel/test-coverage-with-inspector-disabled.js
work fine for me on local, but the test is fails in CI. I might be missing something here. Is the child spawned correctly in the test added?

I might be wrong, but is there a chance it’s working for you locally because you locally compiled a version of Node.js that has the inspector disabled, but Travis CI builds the default version with inspector enabled?

I think it might make sense to add something like if (process.features.inspector) common.skip('Inspector enabled'); or something like it to the beginning of the test?

shobhitchittora · 2019-09-18T14:05:25Z

@addaleax Can this be closed and merged now?

addaleax · 2019-09-18T14:28:12Z

@shobhitchittora Yeah, once CI is green with the latest changes this should be good to go 👍

nodejs-github-bot · 2019-09-18T14:28:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25547/

nodejs-github-bot · 2019-09-19T05:12:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25566/

Trott · 2019-09-23T00:03:18Z

@shobhitchittora Can you rebase to get rid of the conflict?

exception handling for the case when profile is not bootstrapped when coverage is enabled. Fixes: nodejs#29542

Trott · 2019-09-23T02:18:24Z

@shobhitchittora Can you rebase to get rid of the conflict?

Never mind. I did it myself. At least one re-review would be good. @addaleax @joyeecheung

nodejs-github-bot · 2019-09-23T02:19:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25641/

Add exception handling for the case when profile is not bootstrapped when coverage is enabled. Fixes: #29542 PR-URL: #29552 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax · 2019-09-23T10:04:47Z

Landed in fdd5d4a 🎉 Thanks for the PR!

Add exception handling for the case when profile is not bootstrapped when coverage is enabled. Fixes: #29542 PR-URL: #29552 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

shobhitchittora · 2019-09-24T04:34:21Z

Thanks all for merging this.

Add exception handling for the case when profile is not bootstrapped when coverage is enabled. Fixes: #29542 PR-URL: #29552 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

shobhitchittora force-pushed the profiler-bootstrap-exception-handling branch from bb08f04 to e9e049eCompare September 14, 2019 00:32

shobhitchittora changed the title ~~internal/bootstrap: adds exception handling for profiler bootstrap~~bootstrap: adds exception handling for profiler bootstrapSep 14, 2019

devsnek added coverage Issues and PRs related to native coverage support. inspector Issues and PRs related to the V8 inspector protocol labels Sep 14, 2019

shobhitchittora commented Sep 14, 2019
View reviewed changes

Comment threadlib/internal/bootstrap/pre_execution.js Outdated

addaleax reviewed Sep 15, 2019
View reviewed changes

Comment threadtest/fixtures/v8-coverage/subprocess.js Outdated
Comment threadtest/parallel/test-coverage-with-inspector-disabled.js Outdated
Comment threadtest/parallel/test-coverage-with-inspector-disabled.js Outdated
Comment threadtest/parallel/test-coverage-with-inspector-disabled.js Outdated

joyeecheung reviewed Sep 15, 2019
View reviewed changes

Comment threadlib/internal/bootstrap/pre_execution.js Outdated

joyeecheung approved these changes Sep 16, 2019
View reviewed changes

Trott force-pushed the master branch from 1ecc406 to 49cf67eCompare September 17, 2019 16:50

addaleax approved these changes Sep 18, 2019
View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 18, 2019

patilharshal16 approved these changes Sep 19, 2019
View reviewed changes

Shobhit Chittora added 5 commits September 22, 2019 19:15

bootstrap: adds exception handling for profiler bootstrap
f760bc3
exception handling for the case when profile is not bootstrapped when coverage is enabled. Fixes: nodejs#29542

bootstrap: updates the warning and adds test
c18a0dd

bootstrap: return empty string when no cov
8a7be6b

bootstrap: refactor + skip test on inspector enabled
180959e

bootstrap: removes try-caatch and check for inspector
bbb315d

Trott force-pushed the profiler-bootstrap-exception-handling branch from 0700615 to bbb315dCompare September 23, 2019 02:17

patilharshal16 approved these changes Sep 23, 2019
View reviewed changes

addaleax approved these changes Sep 23, 2019
View reviewed changes

addaleax closed this Sep 23, 2019

BridgeAR mentioned this pull request Sep 24, 2019
v12.11.0 proposal #29695
Merged

Uh oh!

Uh oh!

Conversation

shobhitchittora commented Sep 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

shobhitchittora commented Sep 14, 2019

Uh oh!

devsnek commented Sep 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

addaleax commented Sep 14, 2019

Uh oh!

shobhitchittora commented Sep 15, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shobhitchittora commented Sep 18, 2019

Uh oh!

addaleax commented Sep 18, 2019

Uh oh!

nodejs-github-bot commented Sep 18, 2019

Uh oh!

nodejs-github-bot commented Sep 19, 2019

Uh oh!

Trott commented Sep 23, 2019

Uh oh!

Trott commented Sep 23, 2019

Uh oh!

nodejs-github-bot commented Sep 23, 2019

Uh oh!

addaleax commented Sep 23, 2019

Uh oh!

shobhitchittora commented Sep 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shobhitchittora commented Sep 14, 2019•
edited
Loading

devsnek commented Sep 14, 2019•
edited
Loading

shobhitchittora commented Sep 15, 2019•
edited
Loading