Skip to content

#29439 added leap second behavior to napi_create_date and napi_get_date_value - #29569

Closed
levhita wants to merge 1 commit into
nodejs:masterfrom
levhita:#29439-added-leap-seconds-spec-to-docs
Closed

#29439 added leap second behavior to napi_create_date and napi_get_date_value#29569
levhita wants to merge 1 commit into
nodejs:masterfrom
levhita:#29439-added-leap-seconds-spec-to-docs

Conversation

@levhita

@levhitalevhita commented Sep 15, 2019

Copy link
Copy Markdown
Contributor
doc: added leap second behavior to napi_create_date and napi_get_date_value
napi_create_date and napi_get_date_value ignore leap seconds as per
ECMAScript spec that follows POSIX spec for time, comments added to the
documentation where added fo clarify it.
fixes: https://github.com/nodejs/node/issues/29439
Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Sep 15, 2019
@levhita
doc: added leap second behavior to napi_create_date and napi_get_date…
dbd977a
…_value
napi_create_date and napi_get_date_value ignore leap seconds as per
ECMAScript spec that follows POSIX spec for time, comments added to the
documentation where added fo clarify it.
fixes: nodejs#29439
@levhita
levhitaforce-pushed the #29439-added-leap-seconds-spec-to-docs branch from dd49040 to dbd977aCompareSeptember 15, 2019 20:14
@levhitalevhita mentioned this pull request Sep 15, 2019
Closed
@lpinca

lpinca commented Sep 17, 2019

Copy link
Copy Markdown
Member

@nodejs/documentation

@Trott

Trott commented Sep 17, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3913/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 17, 2019
@Trott

Trott commented Sep 17, 2019

Copy link
Copy Markdown
Member

Landed in 90b5cdb

@TrottTrott closed this Sep 17, 2019
Trott pushed a commit that referenced this pull request Sep 17, 2019
@levhita@Trott
doc: add leap second behavior notes for napi methods
90b5cdb
napi_create_date and napi_get_date_value ignore leap seconds as per
ECMAScript spec that follows POSIX spec for time, comments added to the
documentation where added fo clarify it.
PR-URL: #29569Fixes: #29439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Sep 20, 2019
@levhita@targos
doc: add leap second behavior notes for napi methods
33018ab
napi_create_date and napi_get_date_value ignore leap seconds as per
ECMAScript spec that follows POSIX spec for time, comments added to the
documentation where added fo clarify it.
PR-URL: #29569Fixes: #29439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeARBridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@levhita@BridgeAR
doc: add leap second behavior notes for napi methods
55631f4
napi_create_date and napi_get_date_value ignore leap seconds as per
ECMAScript spec that follows POSIX spec for time, comments added to the
documentation where added fo clarify it.
PR-URL: #29569Fixes: #29439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@levhita@lpinca@Trott@nodejs-github-bot