Uh oh!
There was an error while loading. Please reload this page.
src: try showing stack traces when process._fatalException is not set - #29624
Closed
joyeecheung wants to merge 1 commit into
Closed
src: try showing stack traces when process._fatalException is not set#29624joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
So that the stack trace of errors shown in internal code run during bootstrap (before process._fatalException is set) can be printed.
2 tasks
nodejs-github-bot
commented
Sep 24, 2019
Collaborator
joyeecheung
commented
Sep 24, 2019
MemberAuthor
joyeecheung
commented
Sep 24, 2019
MemberAuthor
Before the patch if you make a typo in, e.g. After the patch it looks like this: |
Trott
commented
Sep 24, 2019
Member
@nodejs/collaborators This one could use some reviews. |
Trott
commented
Sep 24, 2019
Member
Is it reasonable/feasible to add a test? |
Fishrock123
approved these changes
Sep 24, 2019
Fishrock123
left a comment
Contributor
There was a problem hiding this comment.
Works for me.
I can't think of an easy or particularly necessary way to test this (since it should only occur on internal dev mistakes).
nodejs-github-bot
commented
Sep 24, 2019
Collaborator
cjihrig
approved these changes
Sep 24, 2019
Trott
commented
Sep 25, 2019
Member
Landed in 355f2ad |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 25, 2019
So that the stack trace of errors shown in internal code run during bootstrap (before process._fatalException is set) can be printed. PR-URL: nodejs#29624 Refs: nodejs#29593 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
approved these changes
Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that the stack trace of errors shown in internal code run during
bootstrap (before process._fatalException is set) can be printed.
Refs: #29593
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes