Uh oh!
There was an error while loading. Please reload this page.
crypto: use byteLength in timingSafeEqual - #29657
Closed
tniessen wants to merge 4 commits into
Closed
Conversation
nodejs-github-bot
commented
Sep 23, 2019
Collaborator
Trott
reviewed
Sep 23, 2019
Uh oh!
There was an error while loading. Please reload this page.
addaleax
approved these changes
Sep 23, 2019
cjihrig
approved these changes
Sep 23, 2019
bnoordhuis
approved these changes
Sep 23, 2019
sam-github
approved these changes
Sep 23, 2019
BridgeAR
approved these changes
Sep 23, 2019
lpinca
approved these changes
Sep 23, 2019
Co-Authored-By: Rich Trott <rtrott@gmail.com>
tniessenforce-pushed
the
ZaneHannanAU-patch-1
branch
from
September 24, 2019 01:53
3b29af9 to
8f12d81Comparenodejs-github-bot
commented
Sep 24, 2019
Collaborator
Trott
commented
Sep 25, 2019
Member
This seems ready to land, but I'm not sure if it should be squashed into one commit, two commits, or three commits. @tniessen |
JungMinu
approved these changes
Sep 25, 2019
tniessen added a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29657 Co-authored-by: ZaneHannanAU <ZaneHannanAU@users.noreply.github.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
tniessen
commented
Sep 25, 2019
MemberAuthor
Landed in 6174306. I decided to squash since it is a fairly trivial change and added |
4 tasks
targos pushed a commit
that referenced
this pull request
Oct 1, 2019
PR-URL: #29657 Co-authored-by: ZaneHannanAU <ZaneHannanAU@users.noreply.github.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revival of #23341 which has shown no activity since last year. I fixed the branch, changed the error description as suggested by @jasnell in #23341 (comment), and simplified the test case.
cc @nodejs/crypto
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes