Skip to content

stream: remove ambiguous code - #29664

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-eos-dead
Closed

stream: remove ambiguous code#29664
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:stream-eos-dead

Conversation

@ronag

@ronagronag commented Sep 23, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This cleans up some ambiguous code. I don't believe this actually causes any observable change of behaviour.

writable, readable is supposed to indicate the type of the stream, which does not change... this PR makes the code less confusing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@mscdex

mscdex commented Sep 23, 2019

Copy link
Copy Markdown
Contributor

s/ambigious/ambiguous/ in commit message

@ronagronag changed the title stream: remove ambigious codestream: remove ambiguous codeSep 23, 2019
@ronag

ronag commented Sep 23, 2019

Copy link
Copy Markdown
MemberAuthor

Not sure what you meant. But I'm guess it's the misspelling. Fixed.

@ronagronag mentioned this pull request Sep 23, 2019
Closed
4 tasks
@ronag

ronag commented Sep 23, 2019

Copy link
Copy Markdown
MemberAuthor

@mcollina

mcollina
mcollina requested changes Sep 23, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mafintosh

Comment threadlib/internal/streams/end-of-stream.js
Comment threadlib/internal/streams/end-of-stream.js
mcollina
mcollina approved these changes Sep 27, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina

mcollina commented Sep 27, 2019

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3939/

JungMinu pushed a commit that referenced this pull request Sep 29, 2019
@ronag@JungMinu
stream: remove ambiguous code
ce62e96
PR-URL: #29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@JungMinu

JungMinu commented Sep 29, 2019

Copy link
Copy Markdown
Member

Landed in ce62e96

@BridgeARBridgeAR added backport-requested-v12.x stream Issues and PRs related to the stream subsystem. labels Oct 9, 2019
@BridgeAR

BridgeAR commented Oct 9, 2019

Copy link
Copy Markdown
Member

@ronag I guess this depends on other PRs that need backporting first? This currently causes conflicts that are not obvious to resolve. Would you be so kind and check if other PRs need backporting first and add that as well / open a backport if you think that's useful here?

@ronag

ronag commented Oct 9, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

This is probably about to be reverted in #29717 (comment).

I will look into backporting this if/when this becomes relevant again.

@MylesBorins

MylesBorins commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

quick ping re: backport

ronag added a commit to nxtedition/node that referenced this pull request Jan 18, 2020
@ronag
stream: remove ambiguous code
ba74fd8
PR-URL: nodejs#29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sxa pushed a commit to sxa/node that referenced this pull request Jan 24, 2020
@ronagStewart Addison
[v12.x backport] stream: remove ambiguous code
8ff774e
PR-URL: nodejs#29664
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@sxa

sxa commented Jan 24, 2020

Copy link
Copy Markdown
Member

@MylesBorins In view of 8c60685#diff-009356850b536cab27b019ba8ad15e72 are you sure this should be backported?

@MylesBorins

MylesBorins commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

Seems like it shouldn't

@kissofirekissofire mentioned this pull request Feb 25, 2021
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Feb 25, 2021
Open
@ron-a20ron-a20 mentioned this pull request Feb 26, 2021
Open
@sitedatasitedata mentioned this pull request Feb 26, 2021
Open
@meghasfdcmeghasfdc mentioned this pull request Feb 26, 2021
Open
@137717unity137717unity mentioned this pull request Feb 26, 2021
Open
@RednickleRednickle mentioned this pull request Feb 26, 2021
Open
This was referenced May 5, 2021
Open
Closed
Closed
Open
Open
@snyk-botsnyk-bot mentioned this pull request May 26, 2021
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Oct 30, 2022
Open
@137717unity137717unity mentioned this pull request Oct 30, 2022
Open
@molllyn1molllyn1 mentioned this pull request Oct 30, 2022
Open
@kissofirekissofire mentioned this pull request Oct 30, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Oct 30, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 31, 2022
Open
@ron-a20ron-a20 mentioned this pull request Oct 31, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 31, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Nov 10, 2022
Open
@kissofirekissofire mentioned this pull request Dec 6, 2023
Open
@137717unity137717unity mentioned this pull request Dec 6, 2023
Open
@ron-a20ron-a20 mentioned this pull request Dec 6, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Dec 6, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Dec 7, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@JungMinuJungMinuJungMinu approved these changes

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@mscdex@mcollina@JungMinu@BridgeAR@MylesBorins@sxa