Skip to content

doc: fix return type - #29696

Closed
exoego wants to merge 2 commits into
nodejs:masterfrom
exoego:doc-crypto
Closed

doc: fix return type#29696
exoego wants to merge 2 commits into
nodejs:masterfrom
exoego:doc-crypto

Conversation

@exoego

@exoegoexoego commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

IIUC, crypto.createDiffieHellmanGroup(name) and its original crypto.getDiffieHellman(groupName) will return a instance of DiffieHellmanGroup which is not a sub type of DiffieHellman.

constinstnace=crypto.createDiffieHellmanGroup("modp14")console.log(instnaceinstanceofcrypto.DiffieHellmanGroup)// trueconsole.log(instnaceinstanceofcrypto.DiffieHellman)// false

on Node.js v12.10.0.

Checklist

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 24, 2019
@Trott

Copy link
Copy Markdown
Member

@nodejs/crypto

@vsemozhetbyt

vsemozhetbyt commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

If this will be accepted, we also need to update the type parser, i.e. to add an entry after this line:

'DiffieHellman': 'crypto.html#crypto_class_diffiehellman',

@TrottTrott added the review wanted PRs that need reviews. label Sep 27, 2019
@Trott

Copy link
Copy Markdown
Member

If this will be accepted, we also need to update the type parser, i.e. to add an entry after this line:

'DiffieHellman': 'crypto.html#crypto_class_diffiehellman',

It will have to happen in this PR or else make doc will fail, I think?

@exoego

Copy link
Copy Markdown
ContributorAuthor

If this will be accepted, we also need to update the type parser, i.e. to add an entry after this line:

'DiffieHellman': 'crypto.html#crypto_class_diffiehellman',

It will have to happen in this PR or else make doc will fail, I think?

Added in 87b26aa

@Trott

Copy link
Copy Markdown
Member

@nodejs/crypto @nodejs/documentation This could use reviews.

@Trott

Trott commented Oct 1, 2019

Copy link
Copy Markdown
Member

@nodejs/collaborators

@Trott

Trott commented Oct 4, 2019

Copy link
Copy Markdown
Member

Rebased and force-pushed.

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3970/

Trott pushed a commit that referenced this pull request Oct 4, 2019
PR-URL: #29696
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Oct 4, 2019

Copy link
Copy Markdown
Member

Landed in 03b7a5a

@TrottTrott closed this Oct 4, 2019
@exoego
exoego deleted the doc-crypto branch October 4, 2019 02:53
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
PR-URL: #29696
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeARBridgeAR mentioned this pull request Oct 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.review wantedPRs that need reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@exoego@Trott@vsemozhetbyt@nodejs-github-bot