Skip to content

doc: clarify pipeline stream cleanup - #29738

Closed
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:doc-pipeline-cleanup
Closed

doc: clarify pipeline stream cleanup#29738
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:doc-pipeline-cleanup

Conversation

@ronag

@ronagronag commented Sep 27, 2019

Copy link
Copy Markdown
Member

Clarify what happens during pipeline cleanup.

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Sep 27, 2019
@ronag
ronagforce-pushed the doc-pipeline-cleanup branch 2 times, most recently from 354b1c5 to 6aa91adCompareSeptember 27, 2019 20:39
ronag
ronag commented Sep 27, 2019
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@ronag
ronagforce-pushed the doc-pipeline-cleanup branch 2 times, most recently from 7355c21 to ad56b01CompareSeptember 27, 2019 20:44
ronag
ronag commented Sep 27, 2019
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@ronag
ronagforce-pushed the doc-pipeline-cleanup branch 3 times, most recently from 5c3f714 to 48d5eedCompareSeptember 27, 2019 20:51
ronag
ronag commented Sep 27, 2019
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@ronag
ronagforce-pushed the doc-pipeline-cleanup branch 2 times, most recently from 1cb17cc to 1c0215eCompareSeptember 27, 2019 21:06
@ronag
ronagforce-pushed the doc-pipeline-cleanup branch from 1c0215e to 4eceebaCompareSeptember 27, 2019 21:07
ronag
ronag commented Sep 27, 2019
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@Trott

Trott commented Sep 29, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3945/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 29, 2019
@Trott

Trott commented Sep 30, 2019

Copy link
Copy Markdown
Member

Landed in 1a3bf4f

@TrottTrott closed this Sep 30, 2019
Trott pushed a commit that referenced this pull request Sep 30, 2019
@ronag@Trott
doc: clarify pipeline stream cleanup
1a3bf4f
PR-URL: #29738
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2019
@ronag@targos
doc: clarify pipeline stream cleanup
2ea4cc0
PR-URL: #29738
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Oct 1, 2019
Merged
@beevelopbeevelop mentioned this pull request Oct 1, 2019
Closed
@kissofirekissofire mentioned this pull request Feb 25, 2021
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Feb 25, 2021
Open
@ron-a20ron-a20 mentioned this pull request Feb 26, 2021
Open
@sitedatasitedata mentioned this pull request Feb 26, 2021
Open
@meghasfdcmeghasfdc mentioned this pull request Feb 26, 2021
Open
@137717unity137717unity mentioned this pull request Feb 26, 2021
Open
@RednickleRednickle mentioned this pull request Feb 26, 2021
Open
This was referenced May 5, 2021
Open
Closed
Closed
Open
Open
@snyk-botsnyk-bot mentioned this pull request May 26, 2021
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Oct 30, 2022
Open
@137717unity137717unity mentioned this pull request Oct 30, 2022
Open
@molllyn1molllyn1 mentioned this pull request Oct 30, 2022
Open
@kissofirekissofire mentioned this pull request Oct 30, 2022
Open
@wedataintelligencewedataintelligence mentioned this pull request Oct 30, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 31, 2022
Open
@ron-a20ron-a20 mentioned this pull request Oct 31, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 31, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Nov 10, 2022
Open
@kissofirekissofire mentioned this pull request Dec 6, 2023
Open
@137717unity137717unity mentioned this pull request Dec 6, 2023
Open
@ron-a20ron-a20 mentioned this pull request Dec 6, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Dec 6, 2023
Open
@wedataintelligencewedataintelligence mentioned this pull request Dec 7, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ronag@Trott@lpinca@nodejs-github-bot