module: Revert remove experimental status from JSON modules by guybedford · Pull Request #29754 · nodejs/node

guybedford · 2019-09-28T19:03:22Z

This reverts commit ec8776d from #27752, adding back the --experimental-json-modules flag to reflect the fact that JSON modules are being reverted for web (whatwg/html#4943) and should not be considered a stable feature.

Tracking issue at nodejs/modules#391 with further information.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

devsnek

the web's issue doesn't match our security model, I don't think we need to destabilise this

littledan · 2019-09-29T07:34:44Z

I think it's possible that we will eventually want to use exactly this syntax for importing JSON modules in Node.js long term, for the reasons @devsnek says. However, the sad state is, we just don't know what the Web will do at this point--it is also possible that the Web may include some changes that we end up wanting to do in Node as well. So the conservative option would be to mark this as experimental again.

devsnek · 2019-09-29T07:40:14Z

we already do this differently than the web (with the current system you have to explicitly type in .json in your import), so i don't think there was ever any way to converge this in the first place.

littledan · 2019-09-29T07:52:24Z

Yes, I agree it's possible that it will never converge. But we haven't really done the design work on the web side so I can't personally draw a conclusion with confidence.

nodejs-github-bot · 2019-10-01T03:44:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25777/

Trott · 2019-10-01T03:49:08Z

It appears that this isn't valid C++ and will not compile.
EDIT: Well, this line is the start of a valid statement, but then the next few lines....you probably get what I mean. This:
20:46:37 ../src/node_options.cc: In constructor ‘node::options_parser::EnvironmentOptionsParser::EnvironmentOptionsParser()’:20:46:37 ../src/node_options.cc:321:35: error: expected ‘)’ before ‘;’ token20:46:37 kAllowedInEnvironment);20:46:37

Trott · 2019-10-01T03:51:26Z

I'm in favor of making it experimental personally on "when in doubt, keep it experimental" grounds, but I would happily defer to Modules WG if there's consensus. Any chance this goes on the Modules WG agenda or something to come to a resolution?

Trott · 2019-10-01T03:52:17Z

Added the "work in progress" label. Feel free to remove once it compiles.

‍

This reverts commit ec8776d.

nodejs-github-bot · 2019-10-01T05:58:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25784/

nodejs-github-bot · 2019-10-02T23:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25824/

Trott

If a Collaborator wants to block this, I suggest making your opposition explicit with a "Request changes" review or a clear comment. As I said above, I'm generally inclined toward "leave it in experimental a bit longer" for anything where there's doubt, but there are certainly many people far more informed on this specific issue than I am....

MylesBorins

LGTM

Trott · 2019-10-09T04:18:23Z

Landed in c0437d2

This reverts commit ec8776d. PR-URL: #29754 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

Trott · 2019-10-09T04:21:19Z

@nodejs/tsc Because this restores a flag that was removed/made unnecessay in Node.js 12.4.0, is this semver-major and should not land except as part of 13.0.0?

Trott · 2019-10-09T04:21:51Z

@nodejs/tsc Because this restores a flag that was removed/made unnecessay in Node.js 12.4.0, is this semver-major and should not land except as part of 13.0.0?

Oh, wait, never mind, all of esm is experimental status so semver rules don't apply.

This reverts commit ec8776d. PR-URL: #29754 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

Notable changes: * build: * Add `--force-context-aware` flag to prevent usage of native node addons that aren't context aware #29631 * deprecations: * Add documentation-only deprecation for `process._tickCallback()` #29781 * esm: * Using JSON modules is experimental again #29754 * fs: * Introduce `opendir()` and `fs.Dir` to iterate through directories #29349 * process: * Add source-map support to stack traces by using `--source-map-support` #29564 * tls: * Honor `pauseOnConnect` option #29635 * Add option for private keys for OpenSSL engines #28973 PR-URL: #29919

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 28, 2019

devsnek previously requested changes Sep 28, 2019
View reviewed changes

addaleax added the esm Issues and PRs related to the ECMAScript Modules implementation. label Sep 28, 2019

Trott reviewed Oct 1, 2019
View reviewed changes

Trott added the wip Issues and PRs that are still a work in progress. label Oct 1, 2019

guybedford force-pushed the json-modules-flag branch 4 times, most recently from 39e2f6b to 683f429Compare October 1, 2019 04:50

guybedford added 3 commits October 1, 2019 01:01

Revert "esm: remove experimental status from JSON modules"
b033f83
This reverts commit ec8776d.

fixup broken option
5dc4167

add to NODE_OPTIONS list
67d6171

guybedford force-pushed the json-modules-flag branch from 683f429 to 67d6171Compare October 1, 2019 05:02

guybedford removed the wip Issues and PRs that are still a work in progress. label Oct 1, 2019

fixup doc spec link
7675c12

Trott approved these changes Oct 2, 2019
View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2019

guybedford mentioned this pull request Oct 7, 2019
esm: Unflag --experimental-modules #29866
Closed
14 tasks

MylesBorins approved these changes Oct 8, 2019
View reviewed changes

Trott closed this Oct 9, 2019

Trott pushed a commit that referenced this pull request Oct 9, 2019
Revert "esm: remove experimental status from JSON modules"
c0437d2
This reverts commit ec8776d. PR-URL: #29754 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
Revert "esm: remove experimental status from JSON modules"
df218ce
This reverts commit ec8776d. PR-URL: #29754 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

BridgeAR mentioned this pull request Oct 10, 2019
v12.12.0 proposal #29919
Merged

aldeed mentioned this pull request Oct 30, 2019
[3.0.0] Update to Node 12 LTS version reactioncommerce/reaction#5770
Closed

damianobarbati mentioned this pull request Nov 13, 2019
Can’t import fs Promises API with ECMAScript Modules #21014
Closed

GeoffreyBooth mentioned this pull request Jan 29, 2022
module: Unflag JSON modules #41736
Merged

Uh oh!

Uh oh!

Conversation

guybedford commented Sep 28, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

devsnek left a comment

Choose a reason for hiding this comment

Uh oh!

littledan commented Sep 29, 2019

Uh oh!

devsnek commented Sep 29, 2019

Uh oh!

littledan commented Sep 29, 2019

Uh oh!

nodejs-github-bot commented Oct 1, 2019

Uh oh!

TrottOct 1, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Trott commented Oct 1, 2019

Uh oh!

Trott commented Oct 1, 2019

Uh oh!

nodejs-github-bot commented Oct 1, 2019

Uh oh!

nodejs-github-bot commented Oct 2, 2019

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

MylesBorins left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Oct 9, 2019

Uh oh!

Trott commented Oct 9, 2019

Uh oh!

Trott commented Oct 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

guybedford commented Sep 28, 2019•
edited
Loading

TrottOct 1, 2019•
edited
Loading