Skip to content

doc: fix process.ppid 'added in' info - #29772

Closed
watson wants to merge 1 commit into
nodejs:masterfrom
watson:ppid-docs
Closed

doc: fix process.ppid 'added in' info#29772
watson wants to merge 1 commit into
nodejs:masterfrom
watson:ppid-docs

Conversation

@watson

@watsonwatson commented Sep 30, 2019

Copy link
Copy Markdown
Member

The PR #16839 originally landed in v9.2.0 but was later backported to v8.10.0 and 6.13.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Sep 30, 2019
Trott
Trott reviewed Oct 1, 2019
View reviewed changes
Comment threaddoc/api/process.md
@watsonwatson added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 1, 2019
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25786/

@watson

watson commented Oct 1, 2019

Copy link
Copy Markdown
MemberAuthor

Probably overkill to run all the tests (been a while since I've used the CI system 😅), but I assume the test failures are unrelated? 🤔

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2019•
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25787/ ✔️

@Trott

Trott commented Oct 1, 2019

Copy link
Copy Markdown
Member

Probably overkill to run all the tests (been a while since I've used the CI system 😅), but I assume the test failures are unrelated? 🤔

For documentation-only changes, you can run node-test-pull-request-lite-pipeline which runs only a linting job and a single (very fast) host for tests.

@Trott

Trott commented Oct 1, 2019

Copy link
Copy Markdown
Member

The fast-track label was added by @watson. If you're a Collaborator, please 👍 here to approve fast-tracking.

@BridgeAR

BridgeAR commented Oct 1, 2019

Copy link
Copy Markdown
Member

@nodejs/tooling @nodejs/releasers it would be great if we could somehow add this information when preparing a new release. We'd need a tool that parses the difference between two *.md file versions and that is capable to automatically change the added information to our standard.

That way such PRs would become obsolete in the future. Right now this information is almost always missing.

@Trott

Trott commented Oct 1, 2019

Copy link
Copy Markdown
Member

Landed in a006465

@TrottTrott closed this Oct 1, 2019
Trott pushed a commit that referenced this pull request Oct 1, 2019
@watson@Trott
doc: improve process.ppid 'added in' info
a006465
PR-URL: #29772
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@watson
watson deleted the ppid-docs branch October 2, 2019 08:58
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@watson@BridgeAR
doc: improve process.ppid 'added in' info
bc48646
PR-URL: #29772
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@watson@nodejs-github-bot@Trott@BridgeAR@jasnell@lpinca@cjihrig