Uh oh!
There was an error while loading. Please reload this page.
crypto: remove arbitrary UTF16 restriction - #29795
Closed
addaleax wants to merge 2 commits into
Closed
Conversation
Since 71f633a, this is no longer necessary. Refs: nodejs#22622Fixes: nodejs#29793
targos
approved these changes
Oct 1, 2019
nodejs-github-bot
commented
Oct 1, 2019
Collaborator
BridgeAR
approved these changes
Oct 1, 2019
lpinca
approved these changes
Oct 1, 2019
cjihrig
approved these changes
Oct 1, 2019
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot
commented
Oct 1, 2019
Collaborator
nodejs-github-bot
commented
Oct 1, 2019
Collaborator
jasnell
approved these changes
Oct 1, 2019
devnexen
approved these changes
Oct 1, 2019
nodejs-github-bot
commented
Oct 1, 2019
Collaborator
Trott
commented
Oct 3, 2019
Member
Landed in 389969e |
Trott pushed a commit
that referenced
this pull request
Oct 3, 2019
Since 71f633a, this is no longer necessary. Refs: #22622Fixes: #29793 PR-URL: #29795 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Oct 9, 2019
Since 71f633a, this is no longer necessary. Refs: #22622Fixes: #29793 PR-URL: #29795 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 71f633a, this is no longer necessary.
Refs: #22622
Fixes: #29793
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes