Uh oh!
There was an error while loading. Please reload this page.
http2: support passing options of http2.connect to net.connect - #29816
Closed
ZYSzys wants to merge 1 commit into
Closed
http2: support passing options of http2.connect to net.connect#29816ZYSzys wants to merge 1 commit into
ZYSzys wants to merge 1 commit into
Conversation
trivikr
commented
Oct 4, 2019
Member
cc @nodejs/http2 |
mcollina
approved these changes
Oct 5, 2019
mcollina
left a comment
Member
There was a problem hiding this comment.
LGTM. We should probably update the docs as well.
cjihrig
reviewed
Oct 5, 2019
| switch (protocol) { | ||
| case 'http:': | ||
| socket = net.connect(options.port || port, options.host || host); | ||
| socket = net.connect({ port, host, ...options }); |
Contributor
There was a problem hiding this comment.
Is it intentional that options.host and options.port would now take precedence over those same fields in authority?
MemberAuthor
There was a problem hiding this comment.
Is it intentional that options.host and options.port would now take precedence over those same fields in authority
I think yes, however this behavior wasn't changed here but in #28584.
jasnell
approved these changes
Oct 5, 2019
cjihrig
approved these changes
Oct 5, 2019
nodejs-github-bot
commented
Oct 5, 2019
Collaborator
trivikr
approved these changes
Oct 5, 2019
nodejs-github-bot
commented
Oct 7, 2019
Collaborator
gengjiawen
approved these changes
Oct 7, 2019
ZYSzys
commented
Oct 7, 2019
MemberAuthor
Landed in 95266db. |
3 tasks
Merged
This was referenced Mar 11, 2021
This was referenced Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #29811
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes