Skip to content

benchmark: add benchmark for vm.createContext - #29845

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:create-context-benchmark
Closed

benchmark: add benchmark for vm.createContext#29845
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:create-context-benchmark

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Oct 4, 2019

Copy link
Copy Markdown
Member

Refs: #29842

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. vm Issues and PRs related to the vm subsystem. labels Oct 4, 2019
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25847/

Trott
Trott approved these changes Oct 5, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I confirmed that test/benchmark/test-benchmark-vm.js still passes with this change.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 5, 2019
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25867/

@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25936/

@joyeecheung

joyeecheung commented Oct 10, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 1294c7e

joyeecheung added a commit that referenced this pull request Oct 10, 2019
@joyeecheung
benchmark: add benchmark for vm.createContext
1294c7e
PR-URL: #29845
Refs: #29842
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggsBethGriggs mentioned this pull request Oct 21, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@joyeecheung@targos
benchmark: add benchmark for vm.createContext
dcdb96c
PR-URL: #29845
Refs: #29842
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targostargos mentioned this pull request Nov 10, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joyeecheung@nodejs-github-bot@Trott@BridgeAR