Uh oh!
There was an error while loading. Please reload this page.
http2: fix file close error condition at respondWithFd - #29884
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Closing a FileHandle almost never fails, so it was hard to notice before that `stream.emit(err)` would not emit an error event due to the missing event name. Destroying the stream with the error seems like the right thing to do in that scenario.
cjihrig
approved these changes
Oct 8, 2019
BridgeAR
approved these changes
Oct 8, 2019
antsmartian
approved these changes
Oct 8, 2019
nodejs-github-bot
commented
Oct 8, 2019
Collaborator
devnexen
approved these changes
Oct 8, 2019
ZYSzys
approved these changes
Oct 8, 2019
lpinca
approved these changes
Oct 8, 2019
lpinca
commented
Oct 8, 2019
Member
I guess there is no way to add a unit test, right? |
addaleax
commented
Oct 8, 2019
MemberAuthor
I’ve tried but couldn’t come up with a good way, no. |
JungMinu
approved these changes
Oct 9, 2019
ronag
approved these changes
Oct 9, 2019
jasnell
approved these changes
Oct 9, 2019
devsnek
approved these changes
Oct 9, 2019
devsnek
left a comment
Member
There was a problem hiding this comment.
we could create a fuse mount that refuses to close files :P
nodejs-github-bot
commented
Oct 11, 2019
Collaborator
Trott
commented
Oct 11, 2019
Member
Landed in 624fa41 |
Trott pushed a commit
that referenced
this pull request
Oct 11, 2019
Closing a FileHandle almost never fails, so it was hard to notice before that `stream.emit(err)` would not emit an error event due to the missing event name. Destroying the stream with the error seems like the right thing to do in that scenario. PR-URL: #29884 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit
that referenced
this pull request
Nov 8, 2019
Closing a FileHandle almost never fails, so it was hard to notice before that `stream.emit(err)` would not emit an error event due to the missing event name. Destroying the stream with the error seems like the right thing to do in that scenario. PR-URL: #29884 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit
that referenced
this pull request
Nov 10, 2019
Closing a FileHandle almost never fails, so it was hard to notice before that `stream.emit(err)` would not emit an error event due to the missing event name. Destroying the stream with the error seems like the right thing to do in that scenario. PR-URL: #29884 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a FileHandle almost never fails, so it was hard to
notice before that
stream.emit(err)would not emit an errorevent due to the missing event name.
Destroying the stream with the error seems like the right thing
to do in that scenario.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes