Skip to content

tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE - #29956

Merged
devsnek merged 1 commit into
nodejs:masterfrom
devsnek:fix/build
Oct 13, 2019
Merged

tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE#29956
devsnek merged 1 commit into
nodejs:masterfrom
devsnek:fix/build

Conversation

@devsnek

@devsnekdevsnek commented Oct 13, 2019•
edited
Loading

Copy link
Copy Markdown
Member

running the repl tests will fail because node will use the system's NODE_REPL_EXTERNAL_MODULE variable. This ensures the built-in repl is used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@devsnekdevsnek added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 13, 2019
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25998/

richardlau
richardlau reviewed Oct 13, 2019
View reviewed changes
Comment threadtools/test.py Outdated
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26000/

@Trott

Trott commented Oct 13, 2019

Copy link
Copy Markdown
Member

Collaborators, 👍 here to fast-track.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 13, 2019
@devsnek
tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE
ea3d5ff
PR-URL: nodejs#29956
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@devsnek
devsnek merged commit ea3d5ff into nodejs:masterOct 13, 2019
@devsnek
devsnek deleted the fix/build branch October 13, 2019 21:24
@Trott

Trott commented Oct 13, 2019

Copy link
Copy Markdown
Member

Fast-tracking requires two approvals but this only received one.

@Trott

Trott commented Oct 13, 2019

Copy link
Copy Markdown
Member

Fast-tracking requires two approvals but this only received one.

(Also: Totally reasonable to not know all the rules, so I'm kinda "eh, whatever" about this sort of thing. IMO, if we want all our rules followed, we need to either simplify them or automate them--maybe both. I hope to try to get a commit queue initiative restarted at Interactive this year, so hopefully we'll get that automation....)

@devsnek

devsnek commented Oct 13, 2019

Copy link
Copy Markdown
MemberAuthor

@Trott oh i thought richard counted, since he approved after i added the label. apologies.

@Trott

Trott commented Oct 13, 2019

Copy link
Copy Markdown
Member

@Trott oh i thought richard counted, since he approved after i added the label. apologies.

Yeah, that stands to reason. Our guide is explicit about a fast-track approval needing to be explicitly approved in addition to approving the change, but I wouldn't be surprised if that often doesn't happen.

@BethGriggsBethGriggs mentioned this pull request Oct 21, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@devsnek@targos
tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE
7fec639
PR-URL: #29956
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@devsnek@targos
tools: fix test runner in presence of NODE_REPL_EXTERNAL_MODULE
8d03013
PR-URL: #29956
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Nov 10, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devsnek@nodejs-github-bot@Trott@richardlau