Skip to content

doc: remove unused Markdown reference links - #29961

Closed
nschonni wants to merge 2 commits into
nodejs:masterfrom
nschonni:remark-lint-inline-cleanup
Closed

doc: remove unused Markdown reference links#29961
nschonni wants to merge 2 commits into
nodejs:masterfrom
nschonni:remark-lint-inline-cleanup

Conversation

@nschonni

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 14, 2019
@nschonni

Copy link
Copy Markdown
MemberAuthor

Could split these 2 commits out to separate PRs, but was just probing to see what inline remark-lint disabled rules could be re-enabled using the latest master of the remark-node-preset

Comment threaddoc/api/n-api.md
externally allocated memory will trigger global garbage collections more
often than it would otherwise.

<!-- it's very convenient to have all the anchors indexed -->

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only document that has it this way, and has been disabled for 2 years

@Trott

Copy link
Copy Markdown
Member

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2019
@Trott

Copy link
Copy Markdown
Member

Landed in 405a280...46648eb

@TrottTrott closed this Oct 16, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 16, 2019
PR-URL: nodejs#29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Trott pushed a commit that referenced this pull request Oct 16, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@nschonni
nschonni deleted the remark-lint-inline-cleanup branch October 16, 2019 12:27
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 23, 2019
targos pushed a commit that referenced this pull request Nov 8, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Nov 8, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targostargos mentioned this pull request Nov 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nschonni@Trott@gireeshpunathil@nodejs-github-bot