Uh oh!
There was an error while loading. Please reload this page.
build: fix version checks in configure.py - #29965
Closed
targos wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Oct 14, 2019
Collaborator
richardlau
approved these changes
Oct 14, 2019
nodejs-github-bot
commented
Oct 14, 2019
Collaborator
devnexen
approved these changes
Oct 14, 2019
lpinca
approved these changes
Oct 14, 2019
bnoordhuis
approved these changes
Oct 14, 2019
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
The long lines are kind of regrettable but I'll get over it.
targos
commented
Oct 18, 2019
MemberAuthor
Landed in d769ebc |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #29927
Refs: #29931