Uh oh!
There was an error while loading. Please reload this page.
doc: make YAML matter consistent in crypto.md - #30016
Merged
Merged
Conversation
Trott
commented
Oct 18, 2019
MemberAuthor
Collaborators, please 👍 here to fast-track. |
Trott
commented
Oct 18, 2019
MemberAuthor
richardlau
approved these changes
Oct 18, 2019
cjihrig
approved these changes
Oct 18, 2019
jasnell
approved these changes
Oct 18, 2019
richardlau
commented
Oct 18, 2019
Member
We should (in another PR) make the tooling throw some sort of error on the original YAML rather than silently incorrectly process it and rely on a human eyeballing the generated docs. |
gireeshpunathil
approved these changes
Oct 18, 2019
This fixes YAML that gets incorrectly processed by our tooling. Refs: nodejs#29910 (comment) PR-URL: nodejs#30016 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Trottforce-pushed
the
fix-yaml-processing
branch
from
October 18, 2019 16:11
fdfc434 to
ce72cd7CompareTrott
commented
Oct 18, 2019
MemberAuthor
Landed in ce72cd7 |
MylesBorins pushed a commit
that referenced
this pull request
Oct 23, 2019
This fixes YAML that gets incorrectly processed by our tooling. Refs: #29910 (comment) PR-URL: #30016 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
commented
Nov 8, 2019
Member
Depends on #29910 to land on v12.x |
targos pushed a commit
that referenced
this pull request
Jan 8, 2020
This fixes YAML that gets incorrectly processed by our tooling. Refs: #29910 (comment) PR-URL: #30016 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit
that referenced
this pull request
Jan 8, 2020
This fixes YAML that gets incorrectly processed by our tooling. Refs: #29910 (comment) PR-URL: #30016 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit
that referenced
this pull request
Feb 6, 2020
This fixes YAML that gets incorrectly processed by our tooling. Refs: #29910 (comment) PR-URL: #30016 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes YAML that gets incorrectly processed by our tooling.
Refs: #29910 (comment)
@vsemozhetbyt
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes