Uh oh!
There was an error while loading. Please reload this page.
test: fix test runner for Python 3 on Windows - #30023
Closed
targos wants to merge 1 commit into
Closed
Conversation
richardlau
previously approved these changes
Oct 18, 2019
richardlau
dismissed
their stale reviewOctober 18, 2019 10:42
Doesn’t seem to be compatible with Python 2
Contributor
On legacy Python, this will raise: |
targos
commented
Oct 18, 2019
MemberAuthor
How can we make it compatible with legacy Python? |
cclauss
commented
Oct 18, 2019
Contributor
Explicitly open files with utf8 encoding, otherwise the system could use another encoding such as latin1 by default.
nodejs-github-bot
commented
Oct 18, 2019
Collaborator
richardlau
approved these changes
Oct 18, 2019
cclauss
approved these changes
Oct 18, 2019
lpinca
approved these changes
Oct 18, 2019
targos
commented
Oct 20, 2019
MemberAuthor
Landed in a4e075f |
targos added a commit
that referenced
this pull request
Oct 20, 2019
Explicitly open files with utf8 encoding, otherwise the system could use another encoding such as latin1 by default. PR-URL: #30023 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 23, 2019
Explicitly open files with utf8 encoding, otherwise the system could use another encoding such as latin1 by default. PR-URL: #30023 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos added a commit
that referenced
this pull request
Nov 8, 2019
Explicitly open files with utf8 encoding, otherwise the system could use another encoding such as latin1 by default. PR-URL: #30023 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit
that referenced
this pull request
Nov 10, 2019
Explicitly open files with utf8 encoding, otherwise the system could use another encoding such as latin1 by default. PR-URL: #30023 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit
that referenced
this pull request
Nov 11, 2019
Explicitly open files with utf8 encoding, otherwise the system could use another encoding such as latin1 by default. PR-URL: #30023 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.
/cc @nodejs/python