Uh oh!
There was an error while loading. Please reload this page.
crypto: guard with OPENSSL_NO_GOST - #30050
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
tniessen
approved these changes
Oct 21, 2019
Uh oh!
There was an error while loading. Please reload this page.
richardlau
approved these changes
Oct 21, 2019
codebytereforce-pushed
the
openssl-no-gost
branch
from
October 21, 2019 16:53
d3a3f77 to
d35b39eComparenodejs-github-bot
commented
Oct 22, 2019
Collaborator
devnexen
approved these changes
Oct 22, 2019
bnoordhuis
approved these changes
Oct 22, 2019
danbev pushed a commit
that referenced
this pull request
Oct 24, 2019
PR-URL: #30050 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
danbev
commented
Oct 24, 2019
Contributor
Landed in a228e22. |
targos pushed a commit
that referenced
this pull request
Oct 24, 2019
PR-URL: #30050 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos pushed a commit
that referenced
this pull request
Nov 8, 2019
PR-URL: #30050 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos pushed a commit
that referenced
this pull request
Nov 10, 2019
PR-URL: #30050 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos pushed a commit
that referenced
this pull request
Nov 11, 2019
PR-URL: #30050 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wraps references to Gost-based NIDs inside
GetSharedSigalgswithOPENSSL_NO_GOST. This helps prevent compilation failures in Electron owing to BoringSSL incompatibilities as well as reduces the size of Node's shipped binary by removing some potentially unnecessary code.cc @tniessen
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes