Skip to content

deps: npm: patch support for 13.x - #30079

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:fix-npm-13
Closed

deps: npm: patch support for 13.x#30079
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:fix-npm-13

Conversation

@MylesBorins

Copy link
Copy Markdown
Contributor

This should keep the npm warning at bay until it is patched
upstream.

/cc @ljharb

Refs: npm/cli#269
Refs: #30066

@nodejs-github-botnodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 23, 2019
@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

Can we please fast track this? I can help prepare a v13.1.0 release asap to get the fix out.

@MylesBorinsMylesBorins changed the title deps: npm: patch support for 13.0.0deps: npm: patch support for 13.xOct 23, 2019
This should keep the npm warning at bay until it is patched
upstream.
Refs: npm/cli#269
Refs: nodejs#30066
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@ljharb

Copy link
Copy Markdown
Member

@MylesBorins v13.0.1 i hope

@ljharb

Copy link
Copy Markdown
Member

(LGTM)

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 23, 2019
@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

landed in d8aa38c

MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
This should keep the npm warning at bay until it is patched
upstream.
Refs: npm/cli#269
Refs: #30066
PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins
MylesBorins deleted the fix-npm-13 branch October 23, 2019 07:33
MylesBorins pushed a commit that referenced this pull request Oct 23, 2019
This should keep the npm warning at bay until it is patched
upstream.
Refs: npm/cli#269
Refs: #30066
PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request Oct 23, 2019
@MylesBorins

Copy link
Copy Markdown
ContributorAuthor

PR for 13.0.1 opened #30081

targos pushed a commit that referenced this pull request Oct 23, 2019
Notable changes:
* deps:
* Fixed a bug in npm 6.12.0 where warnings are emitted on Node.js
13.x. #30079
* esm:
* Changed file extension resolution order of
`--es-module-specifier-resolution=node`to match that of the CommonJS
loader. #29974
PR-URL: #30081
targos pushed a commit that referenced this pull request Oct 23, 2019
Notable changes:
* deps:
* Fixed a bug in npm 6.12.0 where warnings are emitted on Node.js
13.x. #30079
* esm:
* Changed file extension resolution order of
`--es-module-specifier-resolution=node`to match that of the CommonJS
loader. #29974
PR-URL: #30081
targos pushed a commit that referenced this pull request Nov 8, 2019
This should keep the npm warning at bay until it is patched
upstream.
Refs: npm/cli#269
Refs: #30066
PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Nov 10, 2019
This should keep the npm warning at bay until it is patched
upstream.
Refs: npm/cli#269
Refs: #30066
PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request Nov 10, 2019
targos pushed a commit that referenced this pull request Nov 11, 2019
This should keep the npm warning at bay until it is patched
upstream.
Refs: npm/cli#269
Refs: #30066
PR-URL: #30079
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MylesBorins@nodejs-github-bot@ljharb@addaleax@targos