Skip to content

doc: revise os.md - #30102

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:revise-os-doc
Oct 26, 2019
Merged

doc: revise os.md#30102
Trott merged 0 commit into
nodejs:masterfrom
Trott:revise-os-doc

Conversation

@Trott

@TrottTrott commented Oct 24, 2019

Copy link
Copy Markdown
Member

Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 24, 2019
gireeshpunathil
gireeshpunathil reviewed Oct 24, 2019
View reviewed changes
Comment threaddoc/api/os.md Outdated
cjihrig
cjihrig approved these changes Oct 24, 2019
View reviewed changes
Comment threaddoc/api/os.md Outdated
@Trott

Trott commented Oct 26, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4013/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2019
@Trott

Trott commented Oct 26, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4014/

@TrottTrott closed this Oct 26, 2019
@Trott
Trott merged commit 7b2de22 into nodejs:masterOct 26, 2019
@Trott

Trott commented Oct 26, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 7b2de22

targos pushed a commit that referenced this pull request Oct 28, 2019
@Trott@targos
doc: revise os.md
9a71091
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.
PR-URL: #30102
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@Trott@targos
doc: revise os.md
1d427ed
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.
PR-URL: #30102
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@Trott@targos
doc: revise os.md
7189220
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.
PR-URL: #30102
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@Trott@targos
doc: revise os.md
6ebe99b
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.
PR-URL: #30102
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@Trott@targos
doc: revise os.md
ec99287
Revise os.md, mostly making it more concise. In one case, process.md was
revised as well to be consistent with a revision in os.md.
PR-URL: #30102
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@jasnell@cjihrig@gireeshpunathil@trivikr@nodejs-github-bot