Skip to content

tools: undefined name opts -> args in gyptest.py - #30144

Closed
cclauss wants to merge 1 commit into
masterfrom
opts-to-args
Closed

tools: undefined name opts -> args in gyptest.py#30144
cclauss wants to merge 1 commit into
masterfrom
opts-to-args

Conversation

@cclauss

@cclausscclauss commented Oct 27, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^

opts.path is an undefined name in this context while args.path is used on the preceding line and is defined on line 48. Undefined names have the potential to raise NameError at runtime which will halt the script.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss
tools: undefined name opts -> args in gyptest.py
8d92045
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^
```
`opts.path` is an undefined name in this context while `args.path` is used on the preceding line and is defined on line 48. Undefined names have the potential to raise `NameError` at runtime which will halt the script.
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Oct 27, 2019
@cclausscclauss added the python PRs and issues that require attention from people who are familiar with Python. label Oct 27, 2019
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26261/

cclauss added a commit that referenced this pull request Oct 31, 2019
@cclauss
tools: undefined name opts -> args in gyptest.py
db1aab9
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^
```
`opts.path` is an undefined name in this context while `args.path` is
used on the preceding line and is defined on line 48. Undefined names
have the potential to raise `NameError` at runtime which will halt the
script.
PR-URL: #30144
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@cclauss

cclauss commented Oct 31, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in db1aab9

@cclausscclauss closed this Oct 31, 2019
@cclauss
cclauss deleted the opts-to-args branch October 31, 2019 21:12
targos pushed a commit that referenced this pull request Nov 5, 2019
@cclauss@targos
tools: undefined name opts -> args in gyptest.py
bcbcce5
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^
```
`opts.path` is an undefined name in this context while `args.path` is
used on the preceding line and is defined on line 48. Undefined names
have the potential to raise `NameError` at runtime which will halt the
script.
PR-URL: #30144
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targostargos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@cclauss@targos
tools: undefined name opts -> args in gyptest.py
5543511
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^
```
`opts.path` is an undefined name in this context while `args.path` is
used on the preceding line and is defined on line 48. Undefined names
have the potential to raise `NameError` at runtime which will halt the
script.
PR-URL: #30144
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss@targos
tools: undefined name opts -> args in gyptest.py
60c6417
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^
```
`opts.path` is an undefined name in this context while `args.path` is
used on the preceding line and is defined on line 48. Undefined names
have the potential to raise `NameError` at runtime which will halt the
script.
PR-URL: #30144
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss@targos
tools: undefined name opts -> args in gyptest.py
e9fdafa
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^
```
`opts.path` is an undefined name in this context while `args.path` is
used on the preceding line and is defined on line 48. Undefined names
have the potential to raise `NameError` at runtime which will halt the
script.
PR-URL: #30144
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targostargos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@cclauss@targos
tools: undefined name opts -> args in gyptest.py
309c395
```
./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts'
extra_path = [os.path.abspath(p) for p in opts.path]
^
```
`opts.path` is an undefined name in this context while `args.path` is
used on the preceding line and is defined on line 48. Undefined names
have the potential to raise `NameError` at runtime which will halt the
script.
PR-URL: #30144
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
@trivikrtrivikrtrivikr approved these changes
@TrottTrottAwaiting requested review from Trott
@sam-githubsam-githubAwaiting requested review from sam-github
@bnoordhuisbnoordhuisAwaiting requested review from bnoordhuis

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.pythonPRs and issues that require attention from people who are familiar with Python.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cclauss@nodejs-github-bot@lpinca@targos@cjihrig@gengjiawen@richardlau@trivikr