Skip to content

build: fix pkg-config search for libnghttp2 - #30145

Closed
bnoordhuis wants to merge 2 commits into
nodejs:masterfrom
bnoordhuis:fix30113
Closed

build: fix pkg-config search for libnghttp2#30145
bnoordhuis wants to merge 2 commits into
nodejs:masterfrom
bnoordhuis:fix30113

Conversation

@bnoordhuis

@bnoordhuisbnoordhuis commented Oct 27, 2019

Copy link
Copy Markdown
Member

The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.

This change also removes the hack for libcares in one fell swoop.

Fixes: #30113

@bnoordhuis
build: fix pkg-config search for libnghttp2
70d6ca9
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.
This change also removes the hack for libcares in one fell swoop.
Fixes: nodejs#30113
@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 27, 2019
@bnoordhuisbnoordhuis mentioned this pull request Oct 27, 2019
Closed
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26226/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 27, 2019
legendecas
legendecas reviewed Oct 28, 2019
View reviewed changes
Comment threadconfigure.py Outdated
@bnoordhuis@legendecas
Update configure.py
a6e6d7f
Co-Authored-By: legendecas <legendecas@gmail.com>
@danbev

danbev commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

Landed in efb406c.

@danbevdanbev closed this Oct 31, 2019
danbev pushed a commit that referenced this pull request Oct 31, 2019
@bnoordhuis@danbev
build: fix pkg-config search for libnghttp2
efb406c
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.
This change also removes the hack for libcares in one fell swoop.
Co-Authored-By: legendecas <legendecas@gmail.com>
PR-URL: #30145Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this pull request Nov 5, 2019
@bnoordhuis@targos
build: fix pkg-config search for libnghttp2
b255688
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.
This change also removes the hack for libcares in one fell swoop.
Co-Authored-By: legendecas <legendecas@gmail.com>
PR-URL: #30145Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targostargos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@bnoordhuis@targos
build: fix pkg-config search for libnghttp2
85503bf
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.
This change also removes the hack for libcares in one fell swoop.
Co-Authored-By: legendecas <legendecas@gmail.com>
PR-URL: #30145Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@bnoordhuis@targos
build: fix pkg-config search for libnghttp2
bb42698
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.
This change also removes the hack for libcares in one fell swoop.
Co-Authored-By: legendecas <legendecas@gmail.com>
PR-URL: #30145Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@bnoordhuis@targos
build: fix pkg-config search for libnghttp2
08ad146
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.
This change also removes the hack for libcares in one fell swoop.
Co-Authored-By: legendecas <legendecas@gmail.com>
PR-URL: #30145Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targostargos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@bnoordhuis@targos
build: fix pkg-config search for libnghttp2
468f203
The configure script was searching for 'nghttp2' whereas the actual name
of the package is 'libnghttp2'.
This change also removes the hack for libcares in one fell swoop.
Co-Authored-By: legendecas <legendecas@gmail.com>
PR-URL: #30145Fixes: #30113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@legendecaslegendecaslegendecas approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use libnghttp2.pc instead of nghttp2.pc

10 participants

@bnoordhuis@nodejs-github-bot@danbev@addaleax@lpinca@cjihrig@richardlau@legendecas@trivikr@Trott