Skip to content

tools: git rm -r tools/v8_gypfiles/broken - #30149

Closed
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:git-rm-tools-v8_gypfiles-broken
Closed

tools: git rm -r tools/v8_gypfiles/broken#30149
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:git-rm-tools-v8_gypfiles-broken

Conversation

@cclauss

@cclausscclauss commented Oct 27, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Discovered by #30143 the tools/v8_gypfiles/broken has at least three
files that contain Python 3 syntax errors or call removed Python builtins.

https://travis-ci.com/nodejs/node/jobs/249935565#L267-L275

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 27, 2019
@cclausscclauss added the python PRs and issues that require attention from people who are familiar with Python. label Oct 27, 2019
bnoordhuis
bnoordhuis approved these changes Oct 28, 2019
View reviewed changes

@bnoordhuisbnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2019
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26233/

cclauss added a commit that referenced this pull request Oct 31, 2019
@cclauss
tools: git rm -r tools/v8_gypfiles/broken
1f080fc
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@cclauss

cclauss commented Oct 31, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in 1f080fc

@cclausscclauss closed this Oct 31, 2019
@cclauss
cclauss deleted the git-rm-tools-v8_gypfiles-broken branch October 31, 2019 16:15
targos pushed a commit that referenced this pull request Nov 5, 2019
@cclauss@targos
tools: git rm -r tools/v8_gypfiles/broken
14981f5
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targostargos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@cclauss@targos
tools: git rm -r tools/v8_gypfiles/broken
a36c965
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss@targos
tools: git rm -r tools/v8_gypfiles/broken
27f7d3e
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@cclauss@targos
tools: git rm -r tools/v8_gypfiles/broken
a90ba3a
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targostargos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@cclauss@targos
tools: git rm -r tools/v8_gypfiles/broken
df0fbf2
PR-URL: #30149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
@sam-githubsam-githubAwaiting requested review from sam-github
@TrottTrottAwaiting requested review from Trott

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.pythonPRs and issues that require attention from people who are familiar with Python.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cclauss@nodejs-github-bot@bnoordhuis@lpinca@targos@cjihrig@gengjiawen@richardlau@Trott