Skip to content

src: use forward declaration instead of include - #30159

Closed
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:reduceCompiletimeDeps
Closed

src: use forward declaration instead of include#30159
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:reduceCompiletimeDeps

Conversation

@fhinkel

Copy link
Copy Markdown
Member

Reduce number of includes in header file to reduce build time.

Reduce number of includes in header file to reduce build time.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Oct 29, 2019
@addaleax

Copy link
Copy Markdown
Member

I think this is already covered by #30133?

@fhinkel

Copy link
Copy Markdown
MemberAuthor

I think this is already covered by #30133?

You're right. Somehow I thought that PR doesn't cover stat_watcher. Sorry for the noise.

@fhinkelfhinkel closed this Oct 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@fhinkel@addaleax@nodejs-github-bot