Skip to content

deps: update npm to 6.12.1 - #30164

Closed
mikemimik wants to merge 1 commit into
nodejs:masterfrom
npm:npm-6.12.1
Closed

deps: update npm to 6.12.1#30164
mikemimik wants to merge 1 commit into
nodejs:masterfrom
npm:npm-6.12.1

Conversation

@mikemimik

@mikemimikmikemimik commented Oct 29, 2019

Copy link
Copy Markdown

6.12.1 (2019-10-29)

BUG FIXES

DEPENDENCIES

@nodejs-github-botnodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 29, 2019
@TrottTrott mentioned this pull request Oct 29, 2019
Closed
@MylesBorinsMylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 29, 2019
@MylesBorins

MylesBorins commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

This fixes the node.js 13 bug. I think we should fast track

@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26243/

MylesBorins
MylesBorins approved these changes Oct 29, 2019
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@ljharbljharb mentioned this pull request Oct 29, 2019
Closed
2 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26245/

@Trott

Trott commented Oct 29, 2019

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2080/

@MylesBorins

MylesBorins commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

Landed in efe31e7

MylesBorins pushed a commit that referenced this pull request Oct 30, 2019
Michael Perrotte@MylesBorins
deps: update npm to 6.12.1
efe31e7
PR-URL: #30164
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 5, 2019
Michael Perrotte@targos
deps: update npm to 6.12.1
e312448
PR-URL: #30164
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targostargos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
Michael Perrotte@targos
deps: update npm to 6.12.1
c3b09c2
PR-URL: #30164
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
Michael Perrotte@targos
deps: update npm to 6.12.1
c93475e
PR-URL: #30164
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
Michael Perrotte@targos
deps: update npm to 6.12.1
a0f17a7
PR-URL: #30164
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targostargos mentioned this pull request Nov 10, 2019
Merged
@TrottTrott added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 10, 2019
@TrottTrott mentioned this pull request Nov 10, 2019
Closed
targos pushed a commit that referenced this pull request Nov 11, 2019
Michael Perrotte@targos
deps: update npm to 6.12.1
b88314f
PR-URL: #30164
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gengjiawengengjiawengengjiawen approved these changes
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.notable-changePRs with changes that should be highlighted in changelogs.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mikemimik@MylesBorins@nodejs-github-bot@Trott@addaleax@cjihrig@gengjiawen