Skip to content

src: isolate->Dispose() order consistency - #30181

Closed
codebytere wants to merge 1 commit into
nodejs:masterfrom
codebytere:consistent-dispose
Closed

src: isolate->Dispose() order consistency#30181
codebytere wants to merge 1 commit into
nodejs:masterfrom
codebytere:consistent-dispose

Conversation

@codebytere

@codebyterecodebytere commented Oct 30, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Removes comment from UnregisterIsolate() specifying that Isolate::Dispose() should be called afterUnregisterIsolate() since that's no longer the case.

This was originally added to account for issues in V8 but now there should be no relevant tasks running during either call so their order is fungible. However, for consistency's sake, we were calling most of these in the same order (dispose and then unregister) so this also moves a straggling call from node_worker to bring it in line with all others.

cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Oct 30, 2019
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 30, 2019
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26248/

@codebytere

codebytere commented Nov 1, 2019

Copy link
Copy Markdown
MemberAuthor

Windows Rerun: https://ci.nodejs.org/job/node-test-commit-windows-fanned/30837/

@codebytere

codebytere commented Nov 1, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 312c02d

@codebytere
codebytere deleted the consistent-dispose branch November 1, 2019 21:10
codebytere added a commit that referenced this pull request Nov 1, 2019
@codebytere
src: isolate->Dispose() order consistency
312c02d
PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos pushed a commit that referenced this pull request Nov 5, 2019
@codebytere@targos
src: isolate->Dispose() order consistency
cc1cd2b
PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
@targostargos mentioned this pull request Nov 5, 2019
Merged
targos pushed a commit that referenced this pull request Nov 8, 2019
@codebytere@targos
src: isolate->Dispose() order consistency
77861dd
PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@codebytere@targos
src: isolate->Dispose() order consistency
7b3baab
PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos pushed a commit that referenced this pull request Nov 10, 2019
@codebytere@targos
src: isolate->Dispose() order consistency
3b6a7c5
PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
@targostargos mentioned this pull request Nov 10, 2019
Merged
targos pushed a commit that referenced this pull request Nov 11, 2019
@codebytere@targos
src: isolate->Dispose() order consistency
ab03c29
PR-URL: #30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
@addaleaxaddaleax mentioned this pull request Dec 11, 2019
Closed
addaleax added a commit to addaleax/node that referenced this pull request Dec 12, 2019
@addaleax
src: unregister Isolate with platform before disposing
27d48ed
I previously thought the order of these calls was no longer
relevant. I was wrong.
This commit undoes the changes from 312c02d, adds a comment
explaining why I was wrong, and flips the order of the calls
elsewhere for consistency, the latter having been the goal
of 312c02d.
Fixes: nodejs#30846
Refs: nodejs#30181
@addaleaxaddaleax mentioned this pull request Dec 12, 2019
Closed
2 tasks
Trott pushed a commit that referenced this pull request Dec 14, 2019
@addaleax@Trott
src: unregister Isolate with platform before disposing
25447d8
I previously thought the order of these calls was no longer
relevant. I was wrong.
This commit undoes the changes from 312c02d, adds a comment
explaining why I was wrong, and flips the order of the calls
elsewhere for consistency, the latter having been the goal
of 312c02d.
Fixes: #30846
Refs: #30181
PR-URL: #30909
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@addaleax@MylesBorins
src: unregister Isolate with platform before disposing
d456aa0
I previously thought the order of these calls was no longer
relevant. I was wrong.
This commit undoes the changes from 312c02d, adds a comment
explaining why I was wrong, and flips the order of the calls
elsewhere for consistency, the latter having been the goal
of 312c02d.
Fixes: #30846
Refs: #30181
PR-URL: #30909
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jan 14, 2020
@addaleax@targos
src: unregister Isolate with platform before disposing
ace3e70
I previously thought the order of these calls was no longer
relevant. I was wrong.
This commit undoes the changes from 312c02d, adds a comment
explaining why I was wrong, and flips the order of the calls
elsewhere for consistency, the latter having been the goal
of 312c02d.
Fixes: #30846
Refs: #30181
PR-URL: #30909
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@addaleax@BethGriggs
src: unregister Isolate with platform before disposing
65e5a8a
I previously thought the order of these calls was no longer
relevant. I was wrong.
This commit undoes the changes from 312c02d, adds a comment
explaining why I was wrong, and flips the order of the calls
elsewhere for consistency, the latter having been the goal
of 312c02d.
Fixes: #30846
Refs: #30181
PR-URL: #30909
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleaxaddaleax added the v8 platform Issues and PRs related to Node's v8::Platform implementation. label Feb 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@devnexendevnexendevnexen approved these changes
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.v8 platformIssues and PRs related to Node's v8::Platform implementation.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@codebytere@nodejs-github-bot@addaleax@cjihrig@devnexen@devsnek