Skip to content

src: make AtExit() callbacks run in reverse order - #30230

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:atexit-reverse
Closed

src: make AtExit() callbacks run in reverse order#30230
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:atexit-reverse

Conversation

@addaleax

Copy link
Copy Markdown
Member

This makes the actual behaviour match the documented (and arguably
the correct) behaviour.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

This makes the actual behaviour match the documented (and arguably
the correct) behaviour.
@addaleax
addaleax requested a review from danbevNovember 2, 2019 20:26
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 2, 2019
@addaleaxaddaleax added the embedding Issues and PRs related to embedding Node.js in another project. label Nov 2, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 4, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

addaleax added a commit that referenced this pull request Nov 5, 2019
This makes the actual behaviour match the documented (and arguably
the correct) behaviour.
PR-URL: #30230
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@addaleax

Copy link
Copy Markdown
MemberAuthor

Landed in a4123a8

@addaleaxaddaleax closed this Nov 5, 2019
@addaleax
addaleax deleted the atexit-reverse branch November 5, 2019 19:37
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
This makes the actual behaviour match the documented (and arguably
the correct) behaviour.
PR-URL: #30230
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeARBridgeAR mentioned this pull request Nov 19, 2019
targos pushed a commit that referenced this pull request Dec 1, 2019
This makes the actual behaviour match the documented (and arguably
the correct) behaviour.
PR-URL: #30230
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
This makes the actual behaviour match the documented (and arguably
the correct) behaviour.
PR-URL: #30230
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.embeddingIssues and PRs related to embedding Node.js in another project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@nodejs-github-bot@fhinkel@bnoordhuis@danbev@cjihrig