Skip to content

doc: move inactive Collaborators to emeriti - #30243

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:emeriti-2
Nov 6, 2019
Merged

doc: move inactive Collaborators to emeriti#30243
Trott merged 0 commit into
nodejs:masterfrom
Trott:emeriti-2

Conversation

@Trott

@TrottTrott commented Nov 4, 2019

Copy link
Copy Markdown
Member

Move a handful of inactive Collaborators to emeriti.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 4, 2019
@Trott

Trott commented Nov 4, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4028/

@trivikr

trivikr commented Nov 4, 2019

Copy link
Copy Markdown
Member

Last activity for collaborators:

I think @RReverser should not be moved to emeriti

@trivikrtrivikr mentioned this pull request Nov 4, 2019
Closed
@Trott

Trott commented Nov 4, 2019

Copy link
Copy Markdown
MemberAuthor

I think @RReverser should not be moved to emeriti

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus. That said, I'm happy to pull them out of this PR if they are having second thoughts.

@trivikr

trivikr commented Nov 4, 2019

Copy link
Copy Markdown
Member

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus.

I didn't have conversation with RReverser, my suggestion was solely based on activity. They can be moved to emeritus.

@Trott

Trott commented Nov 4, 2019

Copy link
Copy Markdown
MemberAuthor

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus.

I didn't have conversation with RReverser, my suggestion was solely based on activity. They can be moved to emeritus.

Sounds good. In light of relatively recent comments from them, I just want to give them the opportunity to say "You know what, keep me around, I want to be able to use my comments to approve/reject changes" or whatever. But yeah, if we don't hear otherwise, let's land this as-is.

mhdawson
mhdawson approved these changes Nov 4, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 5, 2019
benjamingr
benjamingr approved these changes Nov 5, 2019
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :]

@TrottTrott closed this Nov 6, 2019
@Trott

Trott commented Nov 6, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in b6201ab

@Trott
Trott merged commit b6201ab into nodejs:masterNov 6, 2019
@brendanashworth

brendanashworth commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

Thank you!

MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@Trott@MylesBorins
doc: move inactive Collaborators to emeriti
15a7032
Move a handful of inactive Collaborators to emeriti.
PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BridgeARBridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@Trott@targos
doc: move inactive Collaborators to emeriti
557ad1a
Move a handful of inactive Collaborators to emeriti.
PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott@MylesBorins
doc: move inactive Collaborators to emeriti
f66f28e
Move a handful of inactive Collaborators to emeriti.
PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@Trott@trivikr@brendanashworth@benjamingr@lpinca@targos@cjihrig@gireeshpunathil@BridgeAR@mhdawson@nodejs-github-bot