Skip to content

src: allow adding linked bindings to Environment - #30274

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:linked-bindings
Closed

src: allow adding linked bindings to Environment#30274
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:linked-bindings

Conversation

@addaleax

@addaleaxaddaleax commented Nov 5, 2019

Copy link
Copy Markdown
Member

This allows manually adding linked bindings to an Environment
instance, without having to register modules at program load in
a global namespace.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
src: allow adding linked bindings to Environment
57a291c
This allows manually adding linked bindings to an `Environment`
instance, without having to register modules at program load in
a global namespace.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 5, 2019
@addaleaxaddaleax added embedding Issues and PRs related to embedding Node.js in another project. semver-minor PRs that contain new features and should be released in the next minor version. labels Nov 5, 2019
gireeshpunathil
gireeshpunathil reviewed Nov 6, 2019
View reviewed changes
Comment threadsrc/node_binding.cc
devsnek
devsnek reviewed Nov 6, 2019
View reviewed changes
Comment threadsrc/api/environment.cc
bnoordhuis
bnoordhuis reviewed Nov 6, 2019
View reviewed changes
Comment threadsrc/env-inl.h Outdated
Comment threadsrc/env-inl.h Outdated
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26427/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26460/

@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26462/

Trott pushed a commit that referenced this pull request Nov 8, 2019
@addaleax@Trott
src: allow adding linked bindings to Environment
e460e14
This allows manually adding linked bindings to an `Environment`
instance, without having to register modules at program load in
a global namespace.
PR-URL: #30274
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott

Trott commented Nov 8, 2019

Copy link
Copy Markdown
Member

Landed in e460e14

@TrottTrott closed this Nov 8, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@addaleax@MylesBorins
src: allow adding linked bindings to Environment
b744070
This allows manually adding linked bindings to an `Environment`
instance, without having to register modules at program load in
a global namespace.
PR-URL: #30274
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BridgeARBridgeAR mentioned this pull request Nov 19, 2019
Merged
MylesBorins added a commit to BridgeAR/node that referenced this pull request Nov 21, 2019
@MylesBorins
2019-11-21, Version 13.2.0 (Current)
8eda60c
Notable changes:
* addons:
* Deprecate one- and two-argument `AtExit()`. Use the three-argument
variant of `AtExit()` or `AddEnvironmentCleanupHook()` instead
(Anna Henningsen) nodejs#30227
* child_process,cluster:
* The `serialization` option is added that allows child process
IPC to use the V8 serialization API (to e.g., pass through data
types like sets or maps) (Anna Henningsen)
nodejs#30162
* deps:
* Update V8 to 7.9
* Update `npm` to 6.13.0 (Ruy Adorno)
nodejs#30271
* embedder:
* Exposes the ability to pass cli flags / options through an API
as embedder (Shelley Vohr)
nodejs#30466
* Allow adding linked bindings to Environment (Anna Henningsen)
nodejs#30274
* esm:
* Unflag --experimental-modules (Guy Bedford)
nodejs#29866
* stream:
* Add `writable.writableCorked` property (Robert Nagy)
nodejs#29012
* worker:
* Allow specifying resource limits (Anna Henningsen)
nodejs#26628
* v8:
* The Serialization API is now stable (Anna Henningsen)
nodejs#30234
PR-URL: nodejs#30547
MylesBorins added a commit that referenced this pull request Nov 21, 2019
@MylesBorins
2019-11-21, Version 13.2.0 (Current)
b8f8f05
Notable changes:
* addons:
* Deprecate one- and two-argument `AtExit()`. Use the three-argument
variant of `AtExit()` or `AddEnvironmentCleanupHook()` instead
(Anna Henningsen) #30227
* child_process,cluster:
* The `serialization` option is added that allows child process
IPC to use the V8 serialization API (to e.g., pass through data
types like sets or maps) (Anna Henningsen)
#30162
* deps:
* Update V8 to 7.9
* Update `npm` to 6.13.0 (Ruy Adorno)
#30271
* embedder:
* Exposes the ability to pass cli flags / options through an API
as embedder (Shelley Vohr)
#30466
* Allow adding linked bindings to Environment (Anna Henningsen)
#30274
* esm:
* Unflag --experimental-modules (Guy Bedford)
#29866
* stream:
* Add `writable.writableCorked` property (Robert Nagy)
#29012
* worker:
* Allow specifying resource limits (Anna Henningsen)
#26628
* v8:
* The Serialization API is now stable (Anna Henningsen)
#30234
PR-URL: #30547
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@addaleax@MylesBorins
src: allow adding linked bindings to Environment
3117ea6
This allows manually adding linked bindings to an `Environment`
instance, without having to register modules at program load in
a global namespace.
PR-URL: #30274
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@addaleax@BethGriggs
src: allow adding linked bindings to Environment
af787b8
This allows manually adding linked bindings to an `Environment`
instance, without having to register modules at program load in
a global namespace.
PR-URL: #30274
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
codebytere added a commit to electron/electron that referenced this pull request Feb 13, 2020
@codebytere
Fixup linked module patch
c2d67e9
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 13, 2020
@codebytere
Fixup linked module patch
45c2434
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 13, 2020
@codebytere
Fixup linked module patch
e4629aa
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 13, 2020
@codebytere
Fixup linked module patch
b6fa6ac
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 15, 2020
@codebytere
Fixup linked module patch
2bcd199
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 18, 2020
@codebytere
Fixup linked module patch
79fe976
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 21, 2020
@codebytere
Fixup linked module patch
84d8c45
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 21, 2020
@codebytere
Fixup linked module patch
c9e2ed8
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 24, 2020
@codebytere
Fixup linked module patch
4ebd553
nodejs/node#30274
codebytere added a commit to electron/electron that referenced this pull request Feb 24, 2020
@electron-bot@codebytere
chore: bump node to v12.16.1 (master) (#22168)
f965b13
* chore: bump node in DEPS to v12.16.0
* Fixup asar support setup patch
nodejs/node#30862
* Fixup InternalCallbackScope patch
nodejs/node#30236
* Fixup GN buildfiles patch
nodejs/node#30755
* Fixup low-level hooks patch
nodejs/node#30466
* Fixup globals require patch
nodejs/node#31643
* Fixup process stream patch
nodejs/node#30862
* Fixup js2c modification patch
nodejs/node#30755
* Fixup internal fs override patch
nodejs/node#30610
* Fixup context-aware warn patch
nodejs/node#30336
* Fixup Node.js with ltcg config
nodejs/node#29388
* Fixup oaepLabel patch
nodejs/node#30917
* Remove redundant ESM test patch
nodejs/node#30997
* Remove redundant cli flag patch
nodejs/node#30466
* Update filenames.json
* Remove macro generation in GN build files
nodejs/node#30755
* Fix some compilation errors upstream
* Add uvwasi to deps
nodejs/node#30258
* Fix BoringSSL incompatibilities
* Fixup linked module patch
nodejs/node#30274
* Add missing sources to GN uv build
libuv/libuv#2347
* Patch some uvwasi incompatibilities
* chore: bump Node.js to v12.6.1
* Remove mark_arraybuffer_as_untransferable.patch
nodejs/node#30549
* Fix uvwasi build failure on win
* Fixup --perf-prof cli option error
* Fixup early cjs module loading
* fix: initialize diagnostics properly
nodejs/node#30025
* Disable new esm syntax specs
nodejs/node#30219
* Fixup v8 weakref hook spec
nodejs/node#29874
* Fix async context timer issue
* Disable monkey-patch-main spec
It relies on nodejs/node#29777, and we don't
override prepareStackTrace.
* Disable new tls specs
nodejs/node#23188
We don't support much of TLS owing to schisms between BoringSSL and
OpenSSL.
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@devsnekdevsnekdevsnek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.embeddingIssues and PRs related to embedding Node.js in another project.lib / srcIssues and PRs related to general changes in the lib or src directory.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@nodejs-github-bot@Trott@bnoordhuis@devsnek@gireeshpunathil