Uh oh!
There was an error while loading. Please reload this page.
tls: refactoring tls_wrap.cc - #30303
Closed
artmaks wants to merge 1 commit into
Closed
Conversation
Store the result of excetuting the function in variable. Instead of excetuting it for multiple times.
addaleax
approved these changes
Nov 6, 2019
richardlau
approved these changes
Nov 6, 2019
devnexen
approved these changes
Nov 6, 2019
cjihrig
approved these changes
Nov 6, 2019
lpinca
approved these changes
Nov 6, 2019
BridgeAR
approved these changes
Nov 6, 2019
nodejs-github-bot
commented
Nov 7, 2019
Collaborator
Trott
commented
Nov 8, 2019
Member
Landed in 632cadd. Thanks for the contribution! 🎉 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 8, 2019
Store the result of excetuting the function in variable. Instead of excetuting it for multiple times. PR-URL: nodejs#30303 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2019
Store the result of excetuting the function in variable. Instead of excetuting it for multiple times. PR-URL: #30303 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
Store the result of excetuting the function in variable. Instead of excetuting it for multiple times. PR-URL: #30303 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
Store the result of excetuting the function in variable. Instead of excetuting it for multiple times. PR-URL: #30303 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store the result of excetuting the function in variable.
Instead of excetuting it for multiple times.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes