Skip to content

fs: cover fs.opendir ERR_INVALID_CALLBACK - #30307

Closed
darky wants to merge 1 commit into
nodejs:masterfrom
darky:test-dir-coverage
Closed

fs: cover fs.opendir ERR_INVALID_CALLBACK#30307
darky wants to merge 1 commit into
nodejs:masterfrom
darky:test-dir-coverage

Conversation

@darky

@darkydarky commented Nov 6, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2019
@addaleaxaddaleax added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2019
@ChALkeRChALkeR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2019
trivikr
trivikr approved these changes Nov 6, 2019
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch covered in this PR: https://coverage.nodejs.org/coverage-b6201abacf36cc49/lib/internal/fs/dir.js.html#L184

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@gireeshpunathilgireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26750/

@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26871/

@Trott

Trott commented Nov 23, 2019

Copy link
Copy Markdown
Member

Landed in aaeafd5

@TrottTrott closed this Nov 23, 2019
Trott pushed a commit that referenced this pull request Nov 23, 2019
@darky@Trott
fs: cover fs.opendir ERR_INVALID_CALLBACK
aaeafd5
PR-URL: #30307
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@darky@addaleax
fs: cover fs.opendir ERR_INVALID_CALLBACK
850c2a7
PR-URL: #30307
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@darky@targos
fs: cover fs.opendir ERR_INVALID_CALLBACK
d7d4fe1
PR-URL: #30307
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@darky@MylesBorins
fs: cover fs.opendir ERR_INVALID_CALLBACK
7ba8037
PR-URL: #30307
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fsIssues and PRs related to the fs subsystem / file system.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@darky@nodejs-github-bot@Trott@ChALkeR@jasnell@addaleax@lpinca@cjihrig@gireeshpunathil@BridgeAR@trivikr