Uh oh!
There was an error while loading. Please reload this page.
deps: backport c281c15 from V8's upstream - #3031
Closed
misterdjules wants to merge 1 commit into
Closed
Conversation
Backport c281c15d6dab8370a7805f0717502d260e0ad433 from V8's upstream to allow post-mortem debugging tools to inspect Buffer instances' length. Original commit message: Add JSTypedArray's length in post-mortem metadata. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1363683002 Cr-Commit-Position: refs/heads/master@{nodejs#30873}
trevnorris
commented
Sep 23, 2015
Contributor
LGTM. Now that Buffer isn't using a weak persistent don't have the same tools as before. Thanks. |
misterdjules
commented
Sep 24, 2015
Author
Thank you @trevnorris. CI tests running. |
misterdjules
commented
Sep 24, 2015
Author
Two tests failed, but I'm confident they're not related to this change. Landing asap. |
misterdjules pushed a commit
that referenced
this pull request
Sep 24, 2015
Backport c281c15d6dab8370a7805f0717502d260e0ad433 from V8's upstream to allow post-mortem debugging tools to inspect Buffer instances' length. Original commit message: Add JSTypedArray's length in post-mortem metadata. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1363683002 Cr-Commit-Position: refs/heads/master@{#30873} PR: #3031 PR-URL: #3031 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
misterdjules
commented
Sep 24, 2015
Author
Landed in c22bcd3. |
misterdjules pushed a commit
that referenced
this pull request
Sep 25, 2015
Backport c281c15d6dab8370a7805f0717502d260e0ad433 from V8's upstream to allow post-mortem debugging tools to inspect Buffer instances' length. Original commit message: Add JSTypedArray's length in post-mortem metadata. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1363683002 Cr-Commit-Position: refs/heads/master@{#30873} PR: #3031 PR-URL: #3031 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This was referenced Sep 30, 2015
rvagg added a commit
that referenced
this pull request
Oct 5, 2015
Notable changes * http: - Fix out-of-order 'finish' event bug in pipelining that can abort execution, fixes DoS vulnerability CVE-2015-7384 (Fedor Indutny) #3128 - Account for pending response data instead of just the data on the current request to decide whether pause the socket or not (Fedor Indutny) #3128 * libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details (Saúl Ibarra Corretgé) #3010 - A better rwlock implementation for all Windows versions - Improved AIX support * v8: - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) #3117 - Backported f782159 from v8's upstream to help speed up Promise introspection (Ben Noordhuis) #3130 - Backported c281c15 from v8's upstream to add JSTypedArray length in post-mortem metadata (Julien Gilli) #3031 PR-URL: #3128
rvagg added a commit
that referenced
this pull request
Oct 5, 2015
Notable changes * http: - Fix out-of-order 'finish' event bug in pipelining that can abort execution, fixes DoS vulnerability CVE-2015-7384 (Fedor Indutny) #3128 - Account for pending response data instead of just the data on the current request to decide whether pause the socket or not (Fedor Indutny) #3128 * libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details (Saúl Ibarra Corretgé) #3010 - A better rwlock implementation for all Windows versions - Improved AIX support * v8: - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) #3117 - Backported f782159 from v8's upstream to help speed up Promise introspection (Ben Noordhuis) #3130 - Backported c281c15 from v8's upstream to add JSTypedArray length in post-mortem metadata (Julien Gilli) #3031 PR-URL: #3128
MylesBorins
commented
Nov 17, 2015
Contributor
landed in v4.x-staging as 5fbb248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport c281c15d6dab8370a7805f0717502d260e0ad433 from V8's upstream to
allow post-mortem debugging tools to inspect Buffer instances' length.
Original commit message:
Add JSTypedArray's length in post-mortem metadata.
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/1363683002
Cr-Commit-Position: refs/heads/master@{#30873}
/cc @nodejs/post-mortem